-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stellar| in UI it seems my user isn't signed in, but the authorization is set in header #4591
Comments
curl: curl 'https://impact-graph.serve.giveth.io/graphql' Response: {"data":{"getDonationById":{"__typename":"Donation","id":"267672","anonymous":false,"amount":0.01,"valueUsd":0.00093387,"currency":"XLM","transactionId":"3aa70c5186376fec01319b3c360d6fd6f71a2101b4472e63d5818007b6400ab3","transactionNetworkId":1500,"chainType":"STELLAR","createdAt":"2024-08-19T13:42:01.252Z","donationType":null,"status":"verified","onramperId":null,"isTokenEligibleForGivback":true,"fromWalletAddress":"GCD5OLWDMUJQ6SGABRR34VCC3PZHU4FSSCZISOUR5JKQLET3WULSPWPY"}}} |
It is related to the conversation we had this morning about not signed user and showing user id in donation table @Meriem-BM |
Another example: |
One solution to minimizing this error for logged-in users is checking the eth or sol address of the donor. At least we can give priority to the donor and show an error to the second person to raise a ticket. WDYT @Meriem-BM ? |
We can release without this improvement IMO. And keep this discussion going later. |
Based on this issue and sign out problem, I rename the title of issue |
and this signed out problem makes this problem related to stellar donation:
link of conversation in discord @Meriem-BM @MoeNick |
Can you test this @maryjaf |
It seems the problem related to showing QR code has been fixed |
Yo hooo :) |
The problem is we need some attribute on the transaction response that we relieve from Stellar that tells this transaction belongs to this donation, like if we could add some meta data (draft donation id), but that's impossible it seems when I checked their docs. |
Response example {
"_links": {
"self": {
"href": "https://horizon.stellar.org/operations/229043776898117633"
},
"transaction": {
"href": "https://horizon.stellar.org/transactions/c62f8396f209be93f9761817f34998a37ded4be8ba34231f0cecc3f115f35831"
},
"effects": {
"href": "https://horizon.stellar.org/operations/229043776898117633/effects"
},
"succeeds": {
"href": "https://horizon.stellar.org/effects?order=desc\u0026cursor=229043776898117633"
},
"precedes": {
"href": "https://horizon.stellar.org/effects?order=asc\u0026cursor=229043776898117633"
}
},
"id": "229043776898117633",
"paging_token": "229043776898117633",
"transaction_successful": true,
"source_account": "GAH4LLWSXSWXBNMH5KG6T3DU2W7H4RVMTH63P2GRQ2VNLNYUUM6SKSJ4",
"type": "payment",
"type_i": 1,
"created_at": "2024-09-03T13:00:08Z",
"transaction_hash": "c62f8396f209be93f9761817f34998a37ded4be8ba34231f0cecc3f115f35831",
"transaction": {
"_links": {
"self": {
"href": "https://horizon.stellar.org/transactions/c62f8396f209be93f9761817f34998a37ded4be8ba34231f0cecc3f115f35831"
},
"account": {
"href": "https://horizon.stellar.org/accounts/GAH4LLWSXSWXBNMH5KG6T3DU2W7H4RVMTH63P2GRQ2VNLNYUUM6SKSJ4"
},
"ledger": {
"href": "https://horizon.stellar.org/ledgers/53328410"
},
"operations": {
"href": "https://horizon.stellar.org/transactions/c62f8396f209be93f9761817f34998a37ded4be8ba34231f0cecc3f115f35831/operations{?cursor,limit,order}",
"templated": true
},
"effects": {
"href": "https://horizon.stellar.org/transactions/c62f8396f209be93f9761817f34998a37ded4be8ba34231f0cecc3f115f35831/effects{?cursor,limit,order}",
"templated": true
},
"precedes": {
"href": "https://horizon.stellar.org/transactions?order=asc\u0026cursor=229043776898117632"
},
"succeeds": {
"href": "https://horizon.stellar.org/transactions?order=desc\u0026cursor=229043776898117632"
},
"transaction": {
"href": "https://horizon.stellar.org/transactions/c62f8396f209be93f9761817f34998a37ded4be8ba34231f0cecc3f115f35831"
}
},
"id": "c62f8396f209be93f9761817f34998a37ded4be8ba34231f0cecc3f115f35831",
"paging_token": "229043776898117632",
"successful": true,
"hash": "c62f8396f209be93f9761817f34998a37ded4be8ba34231f0cecc3f115f35831",
"ledger": 53328410,
"created_at": "2024-09-03T13:00:08Z",
"source_account": "GAH4LLWSXSWXBNMH5KG6T3DU2W7H4RVMTH63P2GRQ2VNLNYUUM6SKSJ4",
"source_account_sequence": "159251434511018762",
"fee_account": "GAH4LLWSXSWXBNMH5KG6T3DU2W7H4RVMTH63P2GRQ2VNLNYUUM6SKSJ4",
"fee_charged": "100",
"max_fee": "10000",
"operation_count": 1,
"envelope_xdr": "AAAAAgAAAAAPxa7SvK1wtYfqjensdNW+fkasmf236NGGqtW3FKM9JQAAJxACNcZWAAArCgAAAAEAAAAAAAAAAAAAAABm1wqpAAAAAAAAAAEAAAABAAAAAA/FrtK8rXC1h+qN6ex01b5+RqyZ/bfo0Yaq1bcUoz0lAAAAAQAAAAAGgSsaLmxc9MVeTBzmQOWVOVufCZ2LSUr0EQCZIrVAeQAAAAAAAAAARlVenAAAAAAAAAABFKM9JQAAAED7pzExdyobOAayPrjs67DLVIoWcze2NJBMjtxj5R04srTwIV8wi5CsYC1HduA3App5UyeZ/oGZbziMPGtlJbMP",
"result_xdr": "AAAAAAAAAGQAAAAAAAAAAQAAAAAAAAABAAAAAAAAAAA=",
"result_meta_xdr": "AAAAAwAAAAAAAAACAAAAAwMtuhoAAAAAAAAAAA/FrtK8rXC1h+qN6ex01b5+RqyZ/bfo0Yaq1bcUoz0lAAAAAExLPzgCNcZWAAArCQAAAAEAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAMAAAAAAy2zYwAAAABm1uHlAAAAAAAAAAEDLboaAAAAAAAAAAAPxa7SvK1wtYfqjensdNW+fkasmf236NGGqtW3FKM9JQAAAABMSz84AjXGVgAAKwoAAAABAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAIAAAAAAAAAAAAAAAAAAAADAAAAAAMtuhoAAAAAZtcIWAAAAAAAAAABAAAABAAAAAMDLboaAAAAAAAAAAAPxa7SvK1wtYfqjensdNW+fkasmf236NGGqtW3FKM9JQAAAABMSz84AjXGVgAAKwoAAAABAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAIAAAAAAAAAAAAAAAAAAAADAAAAAAMtuhoAAAAAZtcIWAAAAAAAAAABAy26GgAAAAAAAAAAD8Wu0rytcLWH6o3p7HTVvn5GrJn9t+jRhqrVtxSjPSUAAAAABfXgnAI1xlYAACsKAAAAAQAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAwAAAAADLboaAAAAAGbXCFgAAAAAAAAAAwMts2MAAAAAAAAAAAaBKxoubFz0xV5MHOZA5ZU5W58JnYtJSvQRAJkitUB5AAAGtAyun1ECNtjnAAAlfQAAAAEAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAMAAAAAAy2i5wAAAABm1oM1AAAAAAAAAAEDLboaAAAAAAAAAAAGgSsaLmxc9MVeTBzmQOWVOVufCZ2LSUr0EQCZIrVAeQAABrRTA/3tAjbY5wAAJX0AAAABAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAIAAAAAAAAAAAAAAAAAAAADAAAAAAMtoucAAAAAZtaDNQAAAAAAAAAAAAAAAA==",
"fee_meta_xdr": "AAAAAgAAAAMDLbmfAAAAAAAAAAAPxa7SvK1wtYfqjensdNW+fkasmf236NGGqtW3FKM9JQAAAABMSz+cAjXGVgAAKwkAAAABAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAIAAAAAAAAAAAAAAAAAAAADAAAAAAMts2MAAAAAZtbh5QAAAAAAAAABAy26GgAAAAAAAAAAD8Wu0rytcLWH6o3p7HTVvn5GrJn9t+jRhqrVtxSjPSUAAAAATEs/OAI1xlYAACsJAAAAAQAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAwAAAAADLbNjAAAAAGbW4eUAAAAA",
"memo_type": "none",
"signatures": [
"+6cxMXcqGzgGsj647Ouwy1SKFnM3tjSQTI7cY+UdOLK08CFfMIuQrGAtR3bgNwKaeVMnmf6BmW84jDxrZSWzDw=="
],
"valid_after": "1970-01-01T00:00:00Z",
"valid_before": "2024-09-03T13:10:01Z",
"preconditions": {
"timebounds": {
"min_time": "0",
"max_time": "1725369001"
}
}
},
"asset_type": "native",
"from": "GAH4LLWSXSWXBNMH5KG6T3DU2W7H4RVMTH63P2GRQ2VNLNYUUM6SKSJ4",
"to": "GADICKY2FZWFZ5GFLZGBZZSA4WKTSW47BGOYWSKK6QIQBGJCWVAHTIV2",
"amount": "117.9999900"
}, |
No I mean no need to pass it to chain. Im eth1 QR code generator and in my draft donation you can save who generated this donation. When you get a green light with chain, before updating the UI you can check on FE the jwt token of the user and find their eth-address, if the donation generator is the same as the user, you can upade the UI and give it a priority, if not, we can wait or save it with a flag as secondary donation. |
Since this issue was related to a sign-out problem and has been moved to "Done," it would be better if the conversation be conducted on the related issue. |
Got you, I think that won't be possible as we handle all that logic on BE, but I have an idea of saving secondary donation, is while the cron job does all that flow we can check if there is another transaction from same source wallet address, to same project address with same amount and before expiration date then save it as well. |
When I try to donate to test base01 project, the success donation page is shown
In the response of query in network log, donationId : id: "267672" is shown that was created on 19 Aug(yesterday)
and in UI it seems my user isn't signed in, but the authorization is set in header
Screen.Recording.2024-08-20.at.4.01.12.PM.mov
The text was updated successfully, but these errors were encountered: