Skip to content
This repository has been archived by the owner on Dec 31, 2024. It is now read-only.

Could not make a trace if a trace exists with that it's title include this trace title (we just should check equality) #565

Open
mohammadranjbarz opened this issue Jul 26, 2021 · 1 comment
Open

Could not make a trace if a trace exists with that it's title include this trace title (we just should check equality) #565

mohammadranjbarz opened this issue Jul 26, 2021 · 1 comment
Assignees
@mohammadranjbarz
Labels
bug

Comments

@mohammadranjbarz
Copy link
Collaborator

mohammadranjbarz commented Jul 26, 2021 •
edited
Loading

https://trace.giveth.io/trace/amin-givether-pan-distribution

This is the log for this event:

Trace title is repetitive. Please select a different title for the trace. {"type":"FeathersError","name":"Forbidden","code":403,"className":"forbidden","errors":{},"stack":"Forbidden: Trace title is repetitive. Please select a different title for the trace.\n at new Forbidden (/home/deploy/feathers-giveth-beta/node_modules/@feathersjs/errors/lib/index.js:107:17)\n at Object. (/home/deploy/feathers-giveth-beta/src/services/traces/checkTraceName.js:28:11)\n at process._tickCallback (internal/process/next_tick.js:68:7)","timestamp":"2021-07-26T14:49:06.491Z”

maybe related to #498
@mohammadranjbarz mohammadranjbarz self-assigned this Jul 26, 2021
@mohammadranjbarz mohammadranjbarz changed the title Processing ProjectAdded` getting fail for a trace Could not make a trace if a trace exists with that it's title include this trace title (we just should check equality) Jul 26, 2021
@mohammadranjbarz
Copy link
Collaborator Author

it fails because title of
https://trace.giveth.io/trace/ramin-givether-pan-distribution
includes this trace title

mohammadranjbarz added a commit that referenced this issue Jul 26, 2021
@mohammadranjbarz
Change regex for checkTraceName to let create trace, if another trace…
580bfb1 
… has parent string of this trace title

related #565
@mohammadranjbarz mohammadranjbarz mentioned this issue Jul 26, 2021
Merged
mohammadranjbarz added a commit that referenced this issue Aug 12, 2021
@mohammadranjbarz
Add test cases to make sure cant create trace repetitive title
1adb786 
related to #565
@mohammadranjbarz mohammadranjbarz mentioned this issue Aug 12, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mohammadranjbarz mohammadranjbarz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mohammadranjbarz