Read data using a background context in the DataStore #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
added
🐞 Bug
laevandus
commented
Dec 23, 2024
Comment on lines
+286
to
+302
| func readAndWait<T>(_ actions: (DatabaseSession) throws -> T) throws -> T { | ||
| let context = viewContext | ||
| var result: T? | ||
| var readError: Error? | ||
| context.performAndWait { | ||
| do { | ||
| result = try actions(context) | ||
| } catch { | ||
| readError = error | ||
| } | ||
| } | ||
| if let result { | ||
| return result | ||
| } else { | ||
| throw readError ?? ClientError.Unknown() | ||
| } | ||
| } |
There was a problem hiding this comment.
Throwing performAndWait is iOS 15 or later, therefore this is not so pretty at the moment.
laevandus
force-pushed
the
fix/data-store-access
branch
from
1810be2 to
56771e1
Compare
SDK Size
|
SDK Performance
|
|
martinmitrevski
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves IOS-626
🎯 Goal
DataStoreis public and therefore we should not have the main thread requirement which can be misused easily📝 Summary
☑️ Contributor Checklist
docs-contentrepo