-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional sorting filter keys for member list query #3535
Add additional sorting filter keys for member list query #3535
Conversation
…or ChannelMemberListQuery
3e195b3
to
b5b91b1
Compare
SDK Performance
|
SDK Size
|
func encode(to encoder: any Encoder) throws { | ||
var container = encoder.singleValueContainer() | ||
switch self { | ||
case .member: | ||
try container.encode("channel_member") | ||
case .moderator: | ||
try container.encode("channel_moderator") | ||
default: | ||
try container.encode(rawValue) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MemberRole
must be encoded like this when using it as member list filter or as sorting key. Note that MemberRole.member
is used for member
and channel_member
values (same with moderation).
8e08dac
to
cf977c5
Compare
Quality Gate passedIssues Measures |
🔗 Issue Links
Resolves: IOS-605
🎯 Goal
No way for filtering by
channel_role
and sorting bychannel_role
in member list queries.📝 Summary
FilterKey.channelRole
andFilterKey.email
ChannelMemberListSortingKey.channelRole
MemberRole.member
aschannel_member
andMemberRole.moderator
aschannel_moderator
🛠 Implementation
🧪 Manual Testing Notes
Example snippet for testing filtering and sorting (
chewbacca
)☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)