Cache NSManagedObjectID instead of the CurrentUserDTO #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
added
🐞 Bug
Generated by 🚫 Danger |
laevandus
commented
Nov 19, 2024
Comment on lines
-126
to
129
| let context = databaseContainer.viewContext | ||
| if Thread.isMainThread { | ||
| currentUserId = context.currentUser?.user.id | ||
| } else { | ||
| context.performAndWait { | ||
| currentUserId = context.currentUser?.user.id | ||
| } | ||
| databaseContainer.backgroundReadOnlyContext.performAndWait { | ||
| currentUserId = databaseContainer.backgroundReadOnlyContext.currentUser?.user.id | ||
| } | ||
| self.currentUserId = currentUserId |
There was a problem hiding this comment.
This looked odd that we have such check here, therefore I changed it around.
SDK Size
|
SDK Performance
|
nuno-vieira
approved these changes
Nov 19, 2024
martinmitrevski
approved these changes
Nov 20, 2024
SDK Size
|
… crashes when accessing the DTO
laevandus
force-pushed
the
fix/rare-current-user-crash
branch
from
1749b7f to
4cda4ec
Compare
|
laevandus
added
🟢 QAed
|
QA was done with @testableapple |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves IOS-21
🎯 Goal
Cache
NSManagedObjectIDinstead of the fullCurrentUserDTOfor increased reliability.📝 Summary
NSManagedObjectIDwhich is less susceptible to possible threading issues (although I haven't found out that his is actually the case, but something seems to have corrupted the DTO in rare cases)🛠 Implementation
We have seen a crash when NSManagedObjectContext's currentUser property is accessed which leads to a crash when the
user.idis called. This PR tries to fix this issue by not keeping the DTO alive all the time and instead asking context to retrieve it instead of (which is not slow).I measured the time taken for accessing the
currentUserproperty and when all the call sites are combined, it was 1 ms.🧪 Manual Testing Notes
Quick testing round of logging in and out
☑️ Contributor Checklist