Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Agora and 100ms related code #3364

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

martinmitrevski
Copy link
Contributor

🎯 Goal

Remove third-party calling SDKs related code. It's a public code, but it's ok to remove it.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

ALT_TEXT

@martinmitrevski martinmitrevski requested a review from a team as a code owner August 7, 2024 08:35
Copy link

github-actions bot commented Aug 7, 2024

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Aug 7, 2024

SDK Size

title develop branch diff status
StreamChat 6.79MB 6.73MB -0.06MB 🚀
StreamChatUI 4.41MB 4.41MB 0.0MB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 8.34 ms 16.6% 🔼 🟢
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 4 ms per s 3.3 ms per s 17.5% 🔼 🟢
Frame rate 75 fps 78.25 fps 4.33% 🔼 🟢
Number of hitches 1 0.6 40.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 12.52 ms -0.16% 🔽 🟡
Duration 2.6 s 2.56 s 1.54% 🔼 🟢
Hitch time ratio 5 ms per s 4.89 ms per s 2.2% 🔼 🟢
Frame rate 72 fps 74.44 fps 3.39% 🔼 🟢
Number of hitches 1.2 1.2 0.0% 🟰 🟢

@martinmitrevski martinmitrevski enabled auto-merge (squash) August 7, 2024 10:17
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.79MB 6.73MB -0.06MB 🚀
StreamChatUI 4.41MB 4.41MB 0.0MB 🟢

Copy link

sonarqubecloud bot commented Aug 7, 2024

@martinmitrevski martinmitrevski merged commit 4a61493 into develop Aug 7, 2024
15 checks passed
@martinmitrevski martinmitrevski deleted the remove-third-party-calls branch August 7, 2024 11:01
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants