Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move headers <body> outside of head.tmpl #109

Open
jcolomb opened this issue Dec 27, 2020 · 2 comments
Open

move headers <body> outside of head.tmpl #109

jcolomb opened this issue Dec 27, 2020 · 2 comments

Comments

@jcolomb
Copy link

jcolomb commented Dec 27, 2020

Describe the feature
I want to change the headers in a docker installed version. If I add head.tmpl in templates/base in the data file, then the deployment fails (gives an error that {{basecommit}} cannot be found.

I tried to paste the commit name instead in the head.tmpl, it builds, but some css seem to be missing as the page does not look good (no column, centering not working,...).

Describe the solution you'd like
I think the best way would be to get a header.tmpl with the body included in head.tmpl at the moment (?). (changing the footer.tmpl works fine).

Describe alternatives you've considered

Additional context
gin-web:live is run via docker, I tried to add the head.tmpl I found here, maybe they are not equivalent, but I could not find a way to test that, as I do not know where the gin-web:live version is... Maybe worth using the release feature of github if different version are in dockers ?
@achilleas-k
Copy link
Member

Changing templates isn't something I'd be keen on doing. I would like even the GIN modifications to be reverted in the repository and added externally through the custom/ directory.

Where is {{basecommit}} coming from? I'm searching for it in the templates but there's nothing like that.

@jcolomb
Copy link
Author

jcolomb commented Jan 7, 2021 •
edited
Loading

sorry, I was with bad internet and could not check, it is {{BuildCommit}} in https://github.com/G-Node/gogs/blob/master/templates/base/head.tmpl

added externally through the custom/ directory.

That would indeed be great, easier to change then. The header you can inject is in the not in the of the template, so it might need some adjustment in gogs to be able to do that (as I cannot do it here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcolomb @achilleas-k