respondd-collector: invalid memory address or nil pointer dereference

[maurerle]

In FFAC we got this error after running for more than 10 days.
The service restarted, nothing did break, but I still wanted to give notice of it.

The error comes from the respondd collector, so it is quite surely unrelated to #236 .

It is called here in the respondd collector:

yanic/respond/collector.go

Line 51 in cc71150

go coll.parser()

And the error comes from a neighbour object which is nil. Calling .Nodeinfo on that throws:

yanic/runtime/nodes.go

Line 130 in cc71150

if neighbour.Nodeinfo != nil {

Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]: time="2024-12-17T12:14:32.367Z" level="info" msg="saving points" data.count=1000 caller="database.go:162 github.com/FreifunkBremen/yanic/database/influx>
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]: panic: runtime error: invalid memory address or nil pointer dereference
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x5aadf0]
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]: goroutine 16 [running]:
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]: github.com/FreifunkBremen/yanic/runtime.(*Nodes).NodeLinks(0xc000120ab0, 0xc000395b60)
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]:         /home/ffac/yanic/runtime/nodes.go:130 +0xab0
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]: github.com/FreifunkBremen/yanic/respond.(*Collector).saveResponse(0xc0000dd3b0, 0xc001565770, 0xc000a1eb40)
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]:         /home/ffac/yanic/respond/collector.go:304 +0x2d0
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]: github.com/FreifunkBremen/yanic/respond.(*Collector).parser(0xc0000dd3b0)
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]:         /home/ffac/yanic/respond/collector.go:257 +0x12f
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]: created by github.com/FreifunkBremen/yanic/respond.NewCollector
Dec 17 12:14:32 monitor.freifunk-aachen.de yanic[288112]:         /home/ffac/yanic/respond/collector.go:51 +0x185
Dec 17 12:14:32 monitor.freifunk-aachen.de systemd[1]: yanic.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Dec 17 12:14:32 monitor.freifunk-aachen.de systemd[1]: yanic.service: Failed with result 'exit-code'.
Dec 17 12:14:32 monitor.freifunk-aachen.de systemd[1]: yanic.service: Consumed 7h 55min 1.917s CPU time.
Dec 17 12:14:37 monitor.freifunk-aachen.de systemd[1]: yanic.service: Scheduled restart job, restart counter is at 5.
Dec 17 12:14:37 monitor.freifunk-aachen.de systemd[1]: Stopped yanic.service - yanic.
Dec 17 12:14:37 monitor.freifunk-aachen.de systemd[1]: yanic.service: Consumed 7h 55min 1.917s CPU time.
Dec 17 12:14:37 monitor.freifunk-aachen.de systemd[1]: Started yanic.service - yanic.