Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upsampling: Statistical biasas of distribution of dataset #15

Open
michaelfeil opened this issue Apr 11, 2024 · 0 comments
Open

Upsampling: Statistical biasas of distribution of dataset #15

michaelfeil opened this issue Apr 11, 2024 · 0 comments

Comments

@michaelfeil
Copy link

michaelfeil commented Apr 11, 2024

I think there are some statistical biases in this implementation for long context engineering.

Concern 1:
For upsample mode, some datasets groups get filtered when their capacity is maxed out. e.g for --down_sample_mode=upsample_code_arxiv_book, the code, arxiv and book datasets will be mostly at the end of our created syntetic dataset.

Concern 2:
Start token_id 1. With the llama-tokenizer, when a single passage is tokenized, it is started by <s> or token_id1. When concetenating different pretokenized texts, its not the same result as if the strings are added and then tokenized together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant