New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all fd are closed in destructor #14

Open

Jens-H opened this issue Nov 28, 2020 · 1 comment · May be fixed by #15

Jens-H commented Nov 28, 2020

fastfilter_cpp/benchmarks/linux-perf-events.h

Line 56 in 5f4f425

~LinuxEvents() { close(fd); }

I believe you are not closing all fd that are opened in the for loop of the constructor.

Best regards
Jens

Member

lemire commented Nov 28, 2020

If you believe that there is an issue, please provide a pull request providing a fix.

lemire linked a pull request

that will close this issue

Fix LinuxEvents destructor to close all fd #15

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment