Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quill 2 Support #45

Open
saulfrr opened this issue Mar 8, 2024 · 10 comments
Open

Quill 2 Support #45

saulfrr opened this issue Mar 8, 2024 · 10 comments

Comments

@saulfrr
Copy link

saulfrr commented Mar 8, 2024

Hi, now that Quill Version 2.0.0-rc.2 is there, do you have plans to support it?

npm ERR! Could not resolve dependency:
npm ERR! peer quill@"^1.3.4" from [email protected]
npm ERR! node_modules/quill-blot-formatter
npm ERR! quill-blot-formatter@"*" from the root project

Thanks.

@LukasKlement
Copy link

This fork works fine with Quill Version 2: https://github.com/juandjara/quill-blot-formatter-mobile

To avoid type errors, make sure to register it with as any:
Quill.register('modules/blotFormatter', BlotFormatter as any);

@adgoncal
Copy link

@saulfrr you can add an override to package.json:

  "overrides": {
    "quill-blot-formatter": {
      "quill": "^2.0.0"
    }
  },

@xwiz
Copy link

xwiz commented May 23, 2024

Thanks, can you open a PR with support for 2.0

@saulfrr you can add an override to package.json:

  "overrides": {
    "quill-blot-formatter": {
      "quill": "^2.0.0"
    }
  },

@enzedonline
Copy link

Overriding the quill version doesn't make it compatible unfortunately. Quill 2 has a very different methodology for applying styles.

The resizing still works fine, but the alignments (found in actions/align/DefaultAligner.js) need updating to the new syntax. Currently, these do not get written to the delta.

@enzedonline
Copy link

enzedonline commented Jun 28, 2024

I have a working version here. It's converted to TypeScript and uses custom Quill formats to apply the alignments.

2024-06-28-162544-ezgif com-optimize

Feel free to clone etc if it's useful to you.

@enzedonline
Copy link

If anyone is looking for an updated version for this package to work with Quill v2, I have this published on npm at https://www.npmjs.com/package/@enzedonline/quill-blot-formatter2

The latest version fixes a lot of bugs to do with the overlay and proxy, particularly when used with a scrollable editor.
Alt/title editing (and option to use title as caption)
Choice to use relative sizing instead of fixed pixel.
Size info display before and during resize.
Custom blots that fix some Quill bugs.
Touch screen compatibility (including resize with pinch gesture).

resize

@adgoncal
Copy link

@enzedonline that's awesome, thank you for sharing. I noticed you removed the License file from your repo. Why?

@enzedonline
Copy link

@adgoncal no reason, probably just got swept up as I was flushing out the config after converting to typescript and updating/removing dependencies etc. I've copied this one back in.

@GlenHeart
Copy link

GlenHeart commented Oct 25, 2024

I directly updated @quill2.0.2 using PNPM. The program ran perfectly, but there were some warnings. Can you tell me what hidden problems there may be?Thanks @enzedonline

@enzedonline
Copy link

@GlenHeart which program? This package or my one? If you're running mine, did you uninstall this one first?

The warnings will depend on your environment but should have been displayed when you installed. Did you check the logs for the warnings, they should be in there, or install with npm i --loglevel warn to filter out everything except warnings and errors.

Other things to look at are

  • npm info <package-name> peerDependencies
  • npm outdated
  • npm-check (you might need to install this one first)
  • npx npm-check-updates

If you're still stuck, maybe your cache is corrupt, try npm cache clean --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants