-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quill 2 Support #45
Comments
This fork works fine with Quill Version 2: https://github.com/juandjara/quill-blot-formatter-mobile To avoid type errors, make sure to register it with as any: |
@saulfrr you can add an override to package.json:
|
Thanks, can you open a PR with support for 2.0
|
Overriding the quill version doesn't make it compatible unfortunately. Quill 2 has a very different methodology for applying styles. The resizing still works fine, but the alignments (found in actions/align/DefaultAligner.js) need updating to the new syntax. Currently, these do not get written to the delta. |
I have a working version here. It's converted to TypeScript and uses custom Quill formats to apply the alignments. Feel free to clone etc if it's useful to you. |
If anyone is looking for an updated version for this package to work with Quill v2, I have this published on npm at https://www.npmjs.com/package/@enzedonline/quill-blot-formatter2 The latest version fixes a lot of bugs to do with the overlay and proxy, particularly when used with a scrollable editor. |
@enzedonline that's awesome, thank you for sharing. I noticed you removed the License file from your repo. Why? |
@adgoncal no reason, probably just got swept up as I was flushing out the config after converting to typescript and updating/removing dependencies etc. I've copied this one back in. |
I directly updated @quill2.0.2 using PNPM. The program ran perfectly, but there were some warnings. Can you tell me what hidden problems there may be?Thanks @enzedonline |
@GlenHeart which program? This package or my one? If you're running mine, did you uninstall this one first? The warnings will depend on your environment but should have been displayed when you installed. Did you check the logs for the warnings, they should be in there, or install with Other things to look at are
If you're still stuck, maybe your cache is corrupt, try |
Hi, now that Quill Version 2.0.0-rc.2 is there, do you have plans to support it?
Thanks.
The text was updated successfully, but these errors were encountered: