-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Music / Audio support #96
Comments
This, combined with a connection to Deemix (or possibly AMR) would be great! |
connect to Lidarr maybe??? |
Lidarr will also be supported this feat req is currently on the roadmap for 1.2.0 |
Yes. This would be great. I've installed this and will be keeping track of it. I noticed that the version I have is 1.2.1. It was said that this feature is on the roadmap for 1.2.0. Does that mean it's already on there... because I don't see it. Or does it mean that it will happen in 1.2.x? |
Music support with sync to lidarr would be great. |
I'd like to find a project to keep track of what I want to buy in the future (wishlist) and get notifications about new albums from my favourite artists. This would be dope. |
That sounds more like a totally different service for tracking artists.
Try finding what already exists and see if they offer an API.
…On Mon, Mar 6, 2023, 11:41 AM Extarys ***@***.***> wrote:
I'd like to find a project to keep track of what I want to buy in the
future (wishlist) and get notifications about new albums from my favourite
artists. This would be dope.
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANUKZW247JTSERMNSIPVVLW2Y4XJANCNFSM5WPWVP4Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I would love to work on adding lidar support if no one is working on it already. |
You're more than welcome to do so and PR c: |
I just wanted to make sure that no one else is working on it. Because it would be a waste of time. Thank you for letting me know :) |
Any updates on this? If not, I could pick it up and try |
Someone else has asked but they have not followed up since. I've been eagerly waiting for this feature as it would make it perfect for my use. Hope you or someone picks it up. |
Sorry for the late reply. I have been quite busy with university and work
the past few months. And, I have made little progress.
A few reasons for my slow progress and lack of motivation are:
1. There is not a comprehensive database for music like TMDB. It might be
because of the genre I am listening to or the language.
2. I am facing the same problem with lidarr. Since it uses Musicbrainz as a
database. I can never find the music I am looking for.
And I have found much easier ways to high quality music and add to jellyfin
without using lidarr
…On Mon, 18 Sept 2023, 4:45 am dcuellar, ***@***.***> wrote:
Any updates on this? If not, I could pick it up and try
Someone else has asked but they. have not followed up since. I've been
eagerly waiting for this feature as it would make it perfect for my use.
Hope you or someone picks it up.
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANKTJDQX7M7JWXTPFBX4PL3X2577ZANCNFSM5WPWVP4Q>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
MusicBrainz is usually alright, no? |
Jellyfin uses MusicBrainz for music by default and it seems to work pretty well in my use. |
Audiobook support would also be amazing. |
What happened to this feature request... It would be amazing having this implemented, however it seems to have been removed from to-do... |
This feature is very low-priority for now. Our focus is movies/series |
Very sad. I use Jellyfin for Movies, Series, and music. Besides the fact that there doesn't seem to be any good solution for music requesting, it'd be great to have it all in one solution anyways. |
I would like to ensure that nobody is currently working on this. If nobody is currently and nobody is planning to start, I'll try to take this on. Development will be slow between University and work, but it's a feature I would like. |
Feel free to take this on. I have yet to make much progress lately as I've been quite busy with university and other things. |
I'm actually moving quicker than I thought. I have some basic lidarr integration already implemented with much more to go. I was wondering what icon set was being used for the rest of the icons on the side of the home page such as discover, music, and series. I just need an SVG to put in there, but I want it to match the rest. |
There's this interesting PR. @Fallenbagel, is this something you'd be open to merging in and supporting if the work was ported over here? |
Yeah. But it requires to be refactored to support jellyfin/emby |
The integration is really rough unless they've improved it since I've checked it out. Might be worth using something other than Musicbrainz for the search. |
@ano0002, are you familiar with this project? I'd hate for your PR to go unmerged. Do you have any insights on it being merged or not? I know the maintainers were hesitant to support for Lidarr, so unless something has changed, I'm not sure if they will ever merge in your work. So transferring your work here, where maintainers are willing to merge, might be worthwhile. Though, that means additional work must be done to support Jellyfin and Emby. |
Hi, thanks for sharing that with me. I'm currently in a really complex exams period so I can't really take time to look into what would be needed to do the port but even if I had time I don't think I'd have the energy to do it. Making the overseerr version was already pretty challenging and exhausting. However, since my fork is open source if anyone wants to port it and has any questions, I'll do my best to answer all of them ;). |
@zachbakerdev How's your work coming? I was thinking about taking a shot at this as well, if no one else is actively working it right now. |
@Svagtlys feel free to start working on it. Worse case, you'll end up joining forces with @zachbakerdev ;) |
I can put a fork up. The only issue I was having was I was going to implement the API using Deezer instead of MusicBrainz due to limited support for covers making the experience less than preferable. Deezer is what I wish to integrate with personally, but a decent chunk of the integrations with Lidarr are functional. I have working search and discovery through Deezer, but now I'm having the different issue of Musicbrainz lacking support for some releases that Deezer has. All Lidarr releases are tagged through MB. |
@zachbakerdev Was the issue with Deezer's API or would using Deezer in Jellyseerr require putting in a PR to Lidarr to enable it searching Deezer as well? |
…class Edited the Jellyfin API hooks to allow accessing music library items, and track musicbrainz ids. Also added the Lidarr API related classes from Overseerr PR #3800 by @ano0002 re Fallenbagel#96
I would have to make a PR to Lidarr that would allow for Deezer to be used. Currently, the only way I could find to transfer from the Deezer search result to Lidarr was to try a search on Musicbrainz, but when you search on musicbrainz, a lot of the items found on Deezer aren't on Musicbrainz. It works fine for albums that are on Musicbrainz, but it's a horrible experience when you go to add an album and it doesn't exist on Musicbrainz and throws an error. Theoretically you could filter the results Deezer returns to results that are available in Musicbrainz, but the Musicbrainz API only lets you submit 1 request per second. This makes it pretty difficult, because search terms may return different results across the 2 APIs. I haven't found a good solution to this yet, so I wouldn't be comfortable submitting a PR with any sort of Deezer integration. |
I appreciate your insight on the Deezer side, I'll definitely be sticking to MusicBrainz for now given that's what I'm familiar with. I'd appreciate any suggestions you have on the open draft PR in regards to UI and using the API! Maybe in the future Deezer will be added to Lidarr and can then be added to Jellyseerr alongside MusicBrainz. |
What would be needed in order to start having support for jellyfin music in the Jellyseerr user issues? Some context: I am interested in this feature, but my usecase is a bit different, I run my server for a few people and have to sort through a bunch of music files put together to share a common library among friends, sometimes there are duplicates (picard automated renaming to an album directory with both mp3 and flac for example), or bad tagging, I would like for my users to have an easy way of reporting it. I’m guessing the issues part can be separated from the requests/downloads but should share some common stuff like the media identification. I don’t have the time to look at it myself to see it implemented but I was interested in seeing if other people shared the same needs as me and if it was better to create a separate feature request for it, depending in how it differs from the work currently being done. |
I would love to have music support. Ombi is very buggy and doesn't work well for me. Bumping this issue! |
@zachbakerdev for deezer support in lidarr check out Lidarr on Steroids https://github.com/youegraillot/lidarr-on-steroids |
I'm more interested in Deezer from the API perspective. The API for Deezer is a lot better than the API for Musicbrainz. Searching for albums and displaying album covers is a lot simpler and a lot cleaner with Deezer than Musicbrainz which is why I brought it up here. There honestly isn't a good way to get decent quality album covers using Musicbrainz, but all Deezer API requests come with the album cover's link as part of the response. Not to mention, Musicbrainz isn't always as up-to-date as the Deezer API. I've found multiple cases where Deezer finds albums that don't exist in the Musicbrainz database. |
@zachbakerdev I can suggest that when you get an album that doesn't have a cover on MB to add it from Deezer :) It's a pain sometimes, but that is part of the beauty of a community project. I admit though that sometimes I get 4 albums and none are on MB, I use this nice tool (https://atisket.pulsewidth.org.uk/) to add releases to the database. |
Once music and audio is supported I would be willing to make a translator that pulls album covers from Deezer if missing from Musicbrainz |
I'm working on the lidarr integration on my side, it actually works, I will optimize things like image fetching, result page combined with movie/tv results, and add a discover trending page like for movie, tv, hope it will helps : https://github.com/0-Pierre/jellyseerr/tree/lidarr |
Would love a pr opened for this 😊 |
I would really appreciate music support, even if it is not yet integrated with lidarr. |
Don't worry, I'm working on it, based on @ano0002 initial work, give me something like 2 weeks to get an almost stable version with additonnals features. |
Even if everything isn't working perfectly yet, feel free to open a draft PR, so we can see how things are progressing 😊 |
Hey, for now, I’m really focused on the core features and working solo to get everything done. I’m reworking the search functionality, image fetching, and related processes. I’ve moved away from using MusicBrainz since the rate limits kept getting triggered and the results were painfully slow. Instead, I’m now working directly with the Lidarr API. It was a real challenge, but it’s finally almost stable. Now, all results load instantly and are far more accurate compared to the initial version from ano0002. I’ll try to dedicate some time to it this weekend, but as I mentioned, in a week or two, the project should be very stable. |
Okay don't worry about the feature, I'll make it myself later when everything is stable. So I stopped working on my branch since your what your doing is way more valuable, and @0-Pierre if you need help for PR of merge when you are done, do not hesitate to ping me, good luck ! |
Hey, this is really nice and interesting if I can help you in any way feel free to tell me. (You can contact me on discord: ano002). |
Description
Hello. I'd like to use Jellyseerr but i only use Jellyfin for music (and music videos) so i can't right now. However, added music support would be really helpful of course.
Data grabbing
There are some great sources from where Jellyseerr can get new data - Musicbrainz, Last.FM, and also some media providers like Qobuz
I don't think this feature request needs additional info.
The text was updated successfully, but these errors were encountered: