Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show only available media #808

Open
1 task done
Wilk-22 opened this issue Jun 11, 2024 · 7 comments
Open
1 task done

Add option to show only available media #808

Wilk-22 opened this issue Jun 11, 2024 · 7 comments
Labels
blocked This issue can't be solved for now enhancement New feature or request

Comments

@Wilk-22
Copy link

Wilk-22 commented Jun 11, 2024

Description

It would be nice to be able to filter out every media that's not already downloaded, with this option being in an easily accessible spot, as sometimes I or any of the other users (who are not as comfortable with tech) want to watch what's already downloaded instead of browsing the infinite library of movies.

Desired Behavior

A switch beside a search bar to show only movies and shows that are already downloaded

Additional Context

An example of what i mean
Untitled

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@Fallenbagel
Copy link
Owner

We will be adding this filter into discoverMovies tab for movies and discoverShows tab for shows as a filter you can select (available, partially available, requested, processing)

@Wilk-22 Wilk-22 changed the title [Feature Request] Add option to show only available media beside search bar [Feature Request] Add option to show only available media Jun 20, 2024
@myselfolli
Copy link
Contributor

myselfolli commented Jun 28, 2024

@Fallenbagel is this already in progress? I'd love to take a stab at it otherwise.

I just implemented a very crude version by misappropriating the LibraryItem toggle, which obviously doesn't allow for the same amount of granularity, but it was a good first issue for me :)

@Fallenbagel
Copy link
Owner

@Fallenbagel is this already in progress? I'd love to take a stab at it otherwise.

Open a pr and we will review it :D

@myselfolli
Copy link
Contributor

myselfolli commented Jun 28, 2024

Open a pr and we will review it :D

Hi so I took a deeper look at this, I am stumbling across one problem:
The way the api call is implemented on the backend currently, the request (with filters) essentially just gets piped to themoviedb, which returns movies sorted by popularity. TMDB obviously has no clue about the availability state locally though.

So I'd have to fetch available media from the db first, enrich it with data from TMDB and then return that as a result. But since TMDB doesn't currently offer a batch fetch endpoint (trello request), I'd have to fetch every movie detail individually, which will suck both for performance and for rate limiting.

How should I proceed?

@gauthier-th
Copy link
Collaborator

Looks like it's something being done on upstream: sct/overseerr#3899

@leejayhsu
Copy link

hello! 👋

I think my PR in overseerr doesn't really satisfy this particular feature request. Mine is simply removing items from the tmdb discover api that are already available in the db. If we were to use my implementation to do the inverse (only return items from the discover api that the plex/jellyfin server has available), there will probably be very few items.

I think @myselfolli probably has the better approach, but I think we both reached the same conclusion of it would require hammering the TMDB api 😆

@gauthier-th
Copy link
Collaborator

Hi, sorry for the mix-up 😅
Yes, until TMDB implements the batch request endpoint that's probably not a good idea.

@gauthier-th gauthier-th changed the title [Feature Request] Add option to show only available media Add option to show only available media Sep 15, 2024
@gauthier-th gauthier-th added the enhancement New feature or request label Sep 15, 2024
@gauthier-th gauthier-th added the blocked This issue can't be solved for now label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue can't be solved for now enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants