Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all @Overwrite Mixins to @Inject #11

Open
halotroop2288 opened this issue Jun 12, 2022 · 3 comments
Open

Convert all @Overwrite Mixins to @Inject #11

halotroop2288 opened this issue Jun 12, 2022 · 3 comments
Assignees
@halotroop2288 @thecatcore
Labels
bug Something isn't working enhancement New feature or request

Comments

@halotroop2288
Copy link
Member

Compatibility is vastly reduced by using @overwrite. The mod may not even be compatible with itself in some cases!

All Mixins that use @overwrite should be carefully rewritten to use @Inject instead.
@halotroop2288 halotroop2288 added bug Something isn't working enhancement New feature or request labels Jun 13, 2022
@FishiaT
Copy link
Contributor

FishiaT commented Jul 5, 2023

This issue should be closed now I think?

@thecatcore
Copy link
Member

I had to use a few overwrites for some mods patches so not completely yet.

@thecatcore
Copy link
Member

There are still 5 Overwrites in the main module as of today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@halotroop2288 halotroop2288

@thecatcore thecatcore

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@halotroop2288 @thecatcore @FishiaT