Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to contribute my local changes #8

Open
marco-aa opened this issue Jul 31, 2017 · 4 comments
Open

How to contribute my local changes #8

marco-aa opened this issue Jul 31, 2017 · 4 comments

Comments

@marco-aa
Copy link

Dear Devs,

i made a local clone and created a local branch and made my changes/contributions.
(Added update method for Userclass and added optional field customFields for update and create)

How can i contribute to you/here ? Normaly i push my branch and make a pull request.

@Fab1en
Copy link
Owner

Fab1en commented Jul 31, 2017

Great ! Go for it, feel free to make pull requests.
There is no guideline for contributors, we would have to build one together.

@marco-aa
Copy link
Author

marco-aa commented Jul 31, 2017

I would like to :)
Do i have to fork first and push my changes into my fork and than i have to make a pull request ? Or is there a easyer way - because i'm not a member ob Fab1en-rocket-chat-rest-client git repository ?

I hope this questions is not so newbeey like - it's the first time a work an github in this way

@Fab1en
Copy link
Owner

Fab1en commented Jul 31, 2017

Yes, you have to fork first, push your changes to your own fork and then make the pull request. That's what @alekseykuleshov did (he seams to have deleted his repo afterwards). I found this question on Stack Overflow that would perhaps help you.

@marco-aa
Copy link
Author

Worked like charme - done ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants