Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background and Text Legibility #49

Open
rossoj85 opened this issue Sep 3, 2022 · 2 comments
Open

Background and Text Legibility #49

rossoj85 opened this issue Sep 3, 2022 · 2 comments

Comments

@rossoj85
Copy link

rossoj85 commented Sep 3, 2022

Embedded an iframe into my vault and it seems to be picking up my vaults background, thus affecting the legibility of the text on site. Maybe an an option to turn this feature off or an option for dark or light background. I was able to fix my particular issue simply by adjusting the style on the iframe element itself.

image

image

image

@FHachez
Copy link
Owner

FHachez commented Sep 15, 2022

@rossoj85 Thanks for reporting the issue. I'm looking into it. It's the first time I encounter the case after embedding dozens of websites.

My understanding is that the site https://marcus.se.net/obsidian-plugin-docs is not setting the background color in light mode. The background is transparent. I had the impression that it's pretty standard to set the default background color of the html and body of your site.

I'm interested if you have ideas because I don't see an easy solution that cover 100% of the cases. For the same price, the text could be white and wouldn't look great on a white background.

By the way, thanks for the doc. It looks really interesting!

@radeksvarz
Copy link

Using Obsidian in dark mode I experience this issue in like 90% of cases.
Workaround is to manually add background to iframe.

I propose the modal dialog had the color picker besides Aspect ration for the background with the last chosen color to remain.

By that I would have to chose only once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants