Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge substrate classes from PLD and MOVPE and place it under IKZ category #125

Open
aalbino2 opened this issue Feb 21, 2024 · 5 comments · May be fixed by #134
Open

merge substrate classes from PLD and MOVPE and place it under IKZ category #125

aalbino2 opened this issue Feb 21, 2024 · 5 comments · May be fixed by #134
Assignees

Comments

@aalbino2
Copy link
Collaborator

I will attemp a merge of the classes and then @hampusnasstrom will carefully revise if everything is included

@aalbino2 aalbino2 self-assigned this Feb 21, 2024
@aalbino2
Copy link
Collaborator Author

This class will be moved in the IKZ baseclasses submodule because it is shared in the institute.

Together to this, I will already add in this submodule the following classes:

  • AFM
  • Light Microscope

@aalbino2
Copy link
Collaborator Author

to close this issue, can you remove the PVD folder in the root of AreaA repo @hampusnasstrom ? Thanks

@hampusnasstrom
Copy link
Collaborator

I still have general things in there. Did we decide on creating an "old" folder or something where I can move it?

@aalbino2
Copy link
Collaborator Author

no, we didn't... you could move it elsewhere like in your personal one?

If you htink this is okay, go for that. These old stuff would only pollute the repo - in view of publishing it in a JOSS

There is also base_sections/nomad-material.processing to be deleted for example

@aalbino2
Copy link
Collaborator Author

@budschi let's meet with @ThomasTSC and Jeremy to discuss the Substrate class where you guys agree on what to record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants