Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Cecil to Editor #70

Closed
hawkwood opened this issue Feb 23, 2022 · 3 comments
Closed

Expose Cecil to Editor #70

hawkwood opened this issue Feb 23, 2022 · 3 comments

Comments

@hawkwood
Copy link

Is your feature request related to a problem?

Some other packages require Cecil for weaving, but installing NuGet
version conflicts with this one.

Describe the solution you'd like

A solution is to expose this version to Unity Editor so that other packages
can use it rather than the NuGet version.

Describe alternatives you've considered

I tried removing Cecil from this package and using NuGet version overall
but I could not get it to work.

Additional context

Please expose all 4 Cecil DLLs by changing the import settings to
checking the Editor box under "Include Platforms"

@thestonefox
Copy link
Member

This isn't actually going to fix the issue, if you include another unity package that has a dependency on their version of Mono.Cecil then it will give errors surrounding duplicate errors. If you remove the unity mono.cecil package manually then unity will just auto bring it back if another package depends on it.

There is a new issue open that is attempting to fundamentally address this issue on all levels so I'll close this one

#72

@hawkwood
Copy link
Author

The other package in my case is Photon Fusion which requires Cecil to be manually installed through package manager. This solution is exactly what I need as I already implemented it by moving Malimbe out to packages folder, and updating the AsmDef. I had additional steps to take in the Fusion AsmDefs, but it is working.

@thestonefox
Copy link
Member

Yeah for any package that wants you to install Mono Cecil manually then this would work for, but it can't be the solution for Malimbe because any package that just references Mono Cecil via its package,json will always try and re-import it if you remove the package manually from the cache and then will always clash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants