Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channel_success and request_success are not ergonomic #380

Open
jeromegn opened this issue Nov 15, 2024 · 1 comment
Open

channel_success and request_success are not ergonomic #380

jeromegn opened this issue Nov 15, 2024 · 1 comment

Comments

@jeromegn
Copy link
Contributor

jeromegn commented Nov 15, 2024 •
edited
Loading

(Sorry, I submitted this too fast with no comment)

We just got bitten by not using channel_success on a channel request for a client that expected a reply (want_reply: true).

I'm wondering why this has to be manually called. Could it be instead inferred from the Result of each handler function?
@jeromegn jeromegn changed the title channel_success and request_success aren' channel_success and request_success are not ergonomic Nov 15, 2024
@Eugeny
Copy link
Owner

Eugeny commented Nov 15, 2024

There's some discussion about it in #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromegn @Eugeny