Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading an experiment with a KnowledgeBase in read mode creates files #1053

Open
lebrice opened this issue Dec 21, 2022 · 0 comments
Open

Loading an experiment with a KnowledgeBase in read mode creates files #1053

lebrice opened this issue Dec 21, 2022 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@lebrice
Copy link
Collaborator

lebrice commented Dec 21, 2022

Describe the bug
Title.

Expected behavior
Loading an experiment in read mode shouldn't create any files.
When loading a KnowledgeBase in read mode, if the host files pointed to in the KnowledgeBase configuration don't exist, then it's alright to just log a warning (as added in #1029 ). However, this shouldn't create any new files.

Added a test with an xfail in #1029 in test_experiment_builder.py.

Steps to reproduce
Run the test I mentioned above.
@lebrice lebrice added the bug Indicates an unexpected problem or unintended behavior label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lebrice