Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the QPIndicator when the connexion quality is good and the control div when in fullscreen #21

Open
DenisTensorWorks opened this issue Feb 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed never-stale

Comments

@DenisTensorWorks
Copy link
Collaborator

Originally opened by @TxMat

Component your feature request relates to

  • Frontend UI library

Problem your feature solves? Please describe.
While the default UI being very clean already, the persistant presence of the controls button and Video QP Indicator even in fullscreen causes a lot of clutter on the game view and can be distracting for players.

Describe the solution you'd like
It'll be nice to have options to tweak to behaviors of these components by hiding them in full screen or only show the connexion indicator when the quality is bad to alert the player.

Additional context
I've tried implementing these changes myself by tinkering with the library
disclaimer : i am not a typescript dev and my changes are probably a bit wonky


Moved from EpicGames/PixelStreamingInfrastructure#496

@lukehb
Copy link
Contributor

lukehb commented Jun 25, 2024

When we get round to implementing this we should add new frontend settings for each of these requests. (This is more modular than just hiding all the UI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed never-stale
Projects
None yet
Development

No branches or pull requests

3 participants