Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastlane issues #214

Open
IzzySoft opened this issue Dec 17, 2024 · 0 comments
Open

Fastlane issues #214

IzzySoft opened this issue Dec 17, 2024 · 0 comments

Comments

@IzzySoft
Copy link

It looks like your full_description.txt is broken:

<h2> Getting Started</h2>
To get started with Mensinator, you can either get it from IzzyOnDroid or from GooglePlay and start tracking your menstrual cycle with ease and privacy.
<strong><a href="https://play.google.com/store/apps/details?id=com.mensinator.app">https://play.google.com/store/apps/details?id=com.mensinator.app</a></strong>
<strong><a href="https://apt.izzysoft.de/fdroid/index/apk/com.mensinator.app</a></strong>


<h2> Contributing </h2>
We welcome contributions to improve Mensinator! If you'd like to contribute, please fork the repository and submit a pull request. For major changes, please open an issue first to discuss your proposed changes. You are also welcome to join our Discord to discuss further or simply to chat with us!
Join us here; <strong><a href="https://discord.gg/tHA2k3bFRN</a></strong>

Note the last line: the quote opens for the href but is not closed again. Same for the last href in the "getting started" block:

image

Oops… and converted to HTML, the number of characters seems to exceed the 4.000 Fastlane is limited to, so it gets truncated…

! com.mensinator.app/en-US/full_description.txt has 4027 chars

This will partly solve by fixing the hrefs (as now <a href for the broken ones becomes &lt;a href – also remember that <strong><a href="https://discord.gg/tHA2k3bFRN"></a></strong> would simply be an invisible element – as a side note, Discord is not really the best choice, not only privacy-wise). The <h2> would destroy overall page structure, compare the adjusted formatting at IzzyOnDroid

image

with the not-adjusted from F-Droid:

image

(for display at the f-droid.org website, they hence simply strip all <h[1-6]> – while at IzzyOnDroid, <h[1-3]> is converted to <p style="font-weight:bold;font-size:larger;"> and <h[4-6]> to <p style="font-weight:bold;">); maybe those could be "demoted" to <h4> or simply converted to <b>? This would work well: full_description.html.zip (I had to zip it or Github would not allow me attaching it) – it's basically yours, with <h2> turned into <h4> and the links corrected. After "conversion" here, that's down to 3.840 chars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant