Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Accept --chain and --base-path from command line #146

Open
gagarin55 opened this issue Mar 26, 2019 · 7 comments
Open

Accept --chain and --base-path from command line #146

gagarin55 opened this issue Mar 26, 2019 · 7 comments

Comments

@gagarin55
Copy link
Member

As a user I expect something like:

emerald account new --base-path=./ --chain=eth
@ghost
Copy link

ghost commented Apr 4, 2019

Just as a supplement to working emerald --base-path=. --chain=eth account new?

@splix
Copy link
Contributor

splix commented Apr 4, 2019

Yes, right. Currently it reads the path from env variable, but should be able to get as an option too

@ghost
Copy link

ghost commented Apr 4, 2019

But, the console already supports this option explicitly, try for example - emerald --base-path=abc --chain=eth account new [1]?

[1] https://github.com/ETCDEVTeam/emerald-vault/blob/master/cli.yml#L16

@splix
Copy link
Contributor

splix commented Apr 4, 2019

@gagarin55 ^^^

@ghost
Copy link

ghost commented Apr 4, 2019

Environment variable is taken only if the --base-path option is not specified explicitly - https://github.com/ETCDEVTeam/emerald-vault/blob/master/src/cmd/mod.rs#L39

@splix
Copy link
Contributor

splix commented Apr 4, 2019

AFAIK there was a problem in some of the cases when it didn't accept it from command line. @gagarin55 can provide more details

@ghost
Copy link

ghost commented Apr 4, 2019

May be it was wrong sequence, for example emerald --base-path=. ... works, but emerald ... --base-path=. isnt't. It works only if options stay before command, not after. But anyway, I am waiting for more details.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants