Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RTW to use new user configuration #3826

Open
ehogan opened this issue Nov 28, 2024 · 1 comment
Open

Update RTW to use new user configuration #3826

ehogan opened this issue Nov 28, 2024 · 1 comment
Assignees
Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow

Comments

@ehogan
Copy link
Contributor

ehogan commented Nov 28, 2024

Changes have been made to the user configuration since the last release (v2.11.0). The RTW now shows the following messages:

${HOME}/cylc-run/recipe_test_workflow/run2/share/lib/python/ESMValCore/esmvalcore/config/_config_object.py:619: ESMValCoreDeprecationWarning: Usage of the single configuration file ~/.esmvaltool/config-user.yml or specifying it via CLI argument `--config_file` has been deprecated in ESMValCore version 2.12.0 and is scheduled for removal in version 2.14.0. Please run `mkdir -p ~/.config/esmvaltool && mv ${HOME}/cylc-run/recipe_test_workflow/run2/share/cycle/20241128T0100Z/config-user.yml ~/.config/esmvaltool` (or alternatively use a custom `--config_dir`) and omit `--config_file`.
  config_obj.reload()
${HOME}/cylc-run/recipe_test_workflow/run2/share/lib/python/ESMValCore/esmvalcore/config/_config_validators.py:403: ESMValCoreDeprecationWarning: The configuration option or command line argument `config_file` has been deprecated in ESMValCore version 2.12.0 and is scheduled for removal in version 2.14.0. Please use the option `config_dir` instead.
  _handle_deprecation(option, deprecated_version, remove_version, more_info)
${HOME}/cylc-run/recipe_test_workflow/run2/share/lib/python/ESMValCore/esmvalcore/_main.py:421: ESMValCoreDeprecationWarning: The method `CFG.load_from_file()` has been deprecated in ESMValCore version 2.12.0 and is scheduled for removal in version 2.14.0. Please use `CFG.load_from_dirs()` instead.
  CFG.load_from_file(kwargs["config_file"])
${HOME}/cylc-run/recipe_test_workflow/run2/share/lib/python/ESMValCore/esmvalcore/config/_config_validators.py:403: ESMValCoreDeprecationWarning: The configuration option or command line argument `config_file` has been deprecated in ESMValCore version 2.12.0 and is scheduled for removal in version 2.14.0. Please use the option `config_dir` instead.
  _handle_deprecation(option, deprecated_version, remove_version, more_info)
${HOME}/cylc-run/recipe_test_workflow/run2/share/lib/python/ESMValCore/esmvalcore/config/_config_validators.py:403: ESMValCoreDeprecationWarning: The configuration option or command line argument `config_file` has been deprecated in ESMValCore version 2.12.0 and is scheduled for removal in version 2.14.0. Please use the option `config_dir` instead.
  _handle_deprecation(option, deprecated_version, remove_version, more_info)
${HOME}/cylc-run/recipe_test_workflow/run2/share/lib/python/ESMValCore/esmvalcore/config/_config_validators.py:403: ESMValCoreDeprecationWarning: The configuration option or command line argument `config_file` has been deprecated in ESMValCore version 2.12.0 and is scheduled for removal in version 2.14.0. Please use the option `config_dir` instead.
  _handle_deprecation(option, deprecated_version, remove_version, more_info)

The RTW should be updated to use the new configuration.

@chrisbillowsMO
Copy link
Contributor

I've removed writing user_config_pathinto the user config file (see 517ab50) - doing so triggers the Deprecation Warning.

There is no option to write the equivalent, new config directory into the config file. (Nothing in the docs and no validator has been added validators

The documentation suggests the CLI call will always taken precendence anyway (here.

Confirmed with @ehogan we can remove it.

chrisbillowsMO added a commit that referenced this issue Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow
Projects
None yet
Development

No branches or pull requests

2 participants