From 8f8bcafd0d0b7484c9325678b1e4cbeabc245648 Mon Sep 17 00:00:00 2001 From: Derek Bruening Date: Thu, 17 Oct 2024 19:15:46 -0400 Subject: [PATCH] Cite #7045 for c-s-o-d improvements --- clients/drcachesim/analyzer.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/clients/drcachesim/analyzer.cpp b/clients/drcachesim/analyzer.cpp index 152fc29f6b8..728648171fa 100644 --- a/clients/drcachesim/analyzer.cpp +++ b/clients/drcachesim/analyzer.cpp @@ -342,8 +342,11 @@ analyzer_tmpl_t::init_scheduler_common( if (i == 0 && shard_type_ == SHARD_BY_CORE) { // This is almost certainly user error. // Better to exit than risk user confusion. - // Ideally this could be detected in analyzer_multi but that is - // not simple so today the user has to re-run. + // XXX i#7045: Ideally this could be reported as an error by the + // scheduler, and also detected early in analyzer_multi to auto-fix + // (when no mode is specified: if the user specifies core-sharding + // there could be config differences and this should be an error), + // but neither is simple so today the user has to re-run. error_string_ = "Re-scheduling a core-sharded-on-disk trace is generally a " "mistake; re-run with -no_core_sharded.\n";