Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for docker secrets (ADMIN_SECRET_FILE) #22

Open
JamScones opened this issue Jul 19, 2023 · 5 comments · May be fixed by #23
Open

Support for docker secrets (ADMIN_SECRET_FILE) #22

JamScones opened this issue Jul 19, 2023 · 5 comments · May be fixed by #23

Comments

@JamScones
Copy link

Eduldap supports admin credential setting via environment variable ADMIN_SECRET.

It would be good if it also supported setting ADMIN_SECRET via a file, so it works nicely with docker secrets.

@JamScones
Copy link
Author

I may well swing back around and make a pull request for this in the next few days.

@binaryape
Copy link
Contributor

You might be able to do via Docker and an env file https://docs.docker.com/compose/environment-variables/env-file/
But that would mean putting the variable name into the secret too

@JamScones
Copy link
Author

Oooo, didn't know about that.

It would still mean that the admin credentials were in the environment though, which is something that should be avoided apparently.

Still, better than committing the creds to the repo!

@binaryape
Copy link
Contributor

I would test this, but: I think "env" variables imported by Docker from a file like that aren't actually visible in the process table as env variables

@binaryape
Copy link
Contributor

Hold on, that's the case for some other apps, but in Docker they're literally available for process as env variables. BELAY THAT SUGGESTION

JamScones pushed a commit to SerotineLTD/eduldap that referenced this issue Jul 24, 2023
@JamScones JamScones linked a pull request Jul 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants