-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for docker secrets (ADMIN_SECRET_FILE) #22
Comments
I may well swing back around and make a pull request for this in the next few days. |
You might be able to do via Docker and an env file https://docs.docker.com/compose/environment-variables/env-file/ |
Oooo, didn't know about that. It would still mean that the admin credentials were in the environment though, which is something that should be avoided apparently. Still, better than committing the creds to the repo! |
I would test this, but: I think "env" variables imported by Docker from a file like that aren't actually visible in the process table as env variables |
Hold on, that's the case for some other apps, but in Docker they're literally available for process as env variables. BELAY THAT SUGGESTION |
Eduldap supports admin credential setting via environment variable ADMIN_SECRET.
It would be good if it also supported setting ADMIN_SECRET via a file, so it works nicely with docker secrets.
The text was updated successfully, but these errors were encountered: