Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display prompt to make user sign in #56

Open
DhanushNehru opened this issue Oct 22, 2023 · 6 comments
Open

Display prompt to make user sign in #56

DhanushNehru opened this issue Oct 22, 2023 · 6 comments
Assignees

Comments

@DhanushNehru
Copy link
Owner

If the user is not signed in display a prompt to make user sign in in order to use the app

@Damon248
Copy link

Thanks, @DhanushNehru for assigning me! I am working on it.

@Damon248
Copy link

Hello, @DhanushNehru, I have a question about this issue. Specifically, how would you like to present the prompt? I have two suggestions:

  1. Display it at the top (or another appropriate location) on the home page if the user is not signed in, while keeping the other components unchanged.

  2. Conditionally render the card component if the user is signed in. If they are not signed in, display the prompt with two sign-in options for Google and GitHub.

@DhanushNehru
Copy link
Owner Author

@Damon248 , I prefer like we can have a login page & only when authorised the next page can be showed

@Damon248
Copy link

@DhanushNehru, I have tried to make a new sign-in component. Kindly check out my pull request if it can solve the issue. Thank you.

@Pooja1823
Copy link

hey, can you assign this issue to me?

@DhanushNehru
Copy link
Owner Author

Hi @Pooja1823 please provide the mock UI here on how you are going to incorporate it, before raising a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants