fix(processing/script/transformers/location): handle class property definitions #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efinitions
The transformers generates wrong (and invalid) JavaScript if a class contains a
property named `locations`.
The generated code currently is `class C{ __get$Loc(location) }`.
sorin-davidoi
commented
Dec 9, 2024
| @@ -68,6 +68,11 @@ const transformer: Transformer<Identifier> = { | |||
| if (parent.type === Syntax.MethodDefinition) | |||
| return false; | |||
|
|
|||
| // Skip: class X { location } | |||
| // @ts-ignore | |||
| if (parent.type === Syntax.PropertyDefinition) | |||
There was a problem hiding this comment.
I'm happy to add this to esotope-hammerhead if there is consensus on merging this.
|
Hello @sorin-davidoi, We sincerely appreciate your contribution and the effort you put into it! Thank you for your contribution! Regarding adding this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The transformers generates wrong (and invalid) JavaScript if a class contains a property named
locations.The generated code for
class C { location }currently isclass C { __get$Loc(location) }.Approach
Extend the transformer to handle class property definitions in the same way other processing exceptions are handled.
Pre-Merge TODO