Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change capitalization from SQLite to Sqlite for types declared in this provider #6

Closed
1 task done
droyad opened this issue Jul 25, 2024 · 0 comments
Closed
1 task done

Change capitalization from SQLite to Sqlite for types declared in this provider #6

droyad opened this issue Jul 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@droyad
Copy link
Member

droyad commented Jul 25, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Description

The .NET Core SQLite libraries we use (provided by Microsoft) only capitalize the S in SQLite (e.g. SqliteConnection). This follows common convention. The .NET Framework library used to use SQLite (e.g. SQLiteConnection).

This provider currently uses the "old" capitalization.

Should we change this so that we match the .NET Core library? While a breaking change, this would bring it into line with what the user using the current SQLite library would expect. (PR #12)

What is the impact?

This is a breaking change.
@droyad droyad added the enhancement New feature or request label Jul 25, 2024
@droyad droyad changed the title Something new Change capitalization from SQLite to Sqlite for types declared in this provider Jul 25, 2024
@droyad droyad pinned this issue Jul 29, 2024
@droyad droyad mentioned this issue Jul 29, 2024
Merged
droyad added a commit that referenced this issue Jul 29, 2024
@droyad
Changed case from SQLite to Sqlite
26c1c55 
#6
@droyad droyad mentioned this issue Jul 29, 2024
Merged
droyad added a commit that referenced this issue Dec 17, 2024
@droyad
Changed case from SQLite to Sqlite (#12)
77fae40 
* Changed case from `SQLite` to `Sqlite`

#6

* Fix up casing in test
@droyad droyad closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@droyad