[BUG] slices.DeleteFunc

[Deleplace]

Hello, while researching for this Go proposal I noticed this code:

			// remove possible paths that do not match possible platforms
			slices.DeleteFunc(possiblePaths, func(s string) bool {
				pform := strings.Split(s, string(os.PathSeparator))[0]
				return !slices.Contains(kvp.platforms, pform)
			})

which doesn't do what it seems to do, and should look like this instead:

			// remove possible paths that do not match possible platforms
			possiblePaths = slices.DeleteFunc(possiblePaths, func(s string) bool {
				pform := strings.Split(s, string(os.PathSeparator))[0]
				return !slices.Contains(kvp.platforms, pform)
			})

I have not tried to execute it.

[paulcacheux]

@Deleplace thanks a lot for reporting this issue, you are fully right that our usage here is wrong. I opened #21077 that should fix it (and add a test for good measure). Thanks again !