Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when job killed for running out of slurm time is very misleading #5177

Open
glennhickey opened this issue Dec 3, 2024 · 1 comment

Comments

@glennhickey
Copy link
Contributor

glennhickey commented Dec 3, 2024

In my experience, if a job runs beyond the max value given for its Slurm partition it gets killed (fine) but with a KeyboardInterrupt which is super cryptic. It always makes me think I've somehow pressed CRTRL-C or something by accident. It's also confusing Cactus users on github:

ComparativeGenomicsToolkit/cactus#1554

Would it be possible to patch Toil to give a more informative error for this?

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1685

@adamnovak
Copy link
Member

This is set up here:

# container cleanup finally blocks can run. Ask for SIGINT so we
# can get the default Python KeyboardInterrupt which third-party
# code is likely to plan for. Make sure to send it to the batch

We could make it configurable or just change it to another signal, but we'd need to make sure that e.g. the WDL and CWL Docker container management code knows to trap that signal, clean up running containers, and then exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants