add cel tests

DanielLiu1123 · Sep 28, 2023 · 8465263 · 8465263
1 parent 32b6692
commit 8465263
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 5 deletions.
diff --git a/examples/proto-validate/src/main/proto/fm/foo/v1/foo.proto b/examples/proto-validate/src/main/proto/fm/foo/v1/foo.proto
@@ -3,16 +3,25 @@ syntax = "proto3";
 package fm.foo.v1;
 
 import "google/protobuf/empty.proto";
-
 import "buf/validate/validate.proto";
 
 option java_multiple_files = true;
 option java_package = "com.freemanan.foo.v1.api";
 
 message Foo {
-  string id = 1;
+  string id = 1 [(buf.validate.field).cel = {
+    id: "id",
+    message: "id length must be at least 5 characters",
+    expression: "this.size() >= 5",
+  }];
   string name = 2 [(buf.validate.field).string = {min_len: 5}];
   repeated string hobbies = 3 [(buf.validate.field).repeated = {min_items: 1}];
+
+  option (buf.validate.message).cel = {
+    id: "foo",
+    message: "not a valid Foo",
+    expression: "this.name != 'aaaaa' && !('coding' in this.hobbies)",
+  };
 }
 
 service FooService {

diff --git a/examples/proto-validate/src/test/java/com/freemanan/example/ProtoValidateAppTest.java b/examples/proto-validate/src/test/java/com/freemanan/example/ProtoValidateAppTest.java
@@ -19,20 +19,46 @@ class ProtoValidateAppTest {
     @Test
     void testInsertFoo() {
         Foo foo = fooBlockingStub.insertFoo(Foo.newBuilder()
-                .setId("001")
+                .setId("00001")
                 .setName("Freeman")
                 .addHobbies("Coding")
                 .build());
-        assertThat(foo.getId()).isEqualTo("001");
+        assertThat(foo.getId()).isEqualTo("00001");
         assertThat(foo.getName()).isEqualTo("Freeman");
     }
 
     @Test
     void testInsertFoo_whenInvalidArgument() {
         assertThatCode(() -> fooBlockingStub.insertFoo(
-                        Foo.newBuilder().setId("001").setName("Free").build()))
+                        Foo.newBuilder().setId("00001").setName("Free").build()))
                 .isInstanceOf(StatusRuntimeException.class)
                 .hasMessage(
                         "INVALID_ARGUMENT: value length must be at least 5 characters, value must contain at least 1 item(s)");
     }
+
+    @Test
+    void testInsertFoo_whenUsingCel() {
+        assertThatCode(() -> fooBlockingStub.insertFoo(Foo.newBuilder()
+                        .setId("") // invalid
+                        .setName("aaaaa") // invalid
+                        .addHobbies("movies")
+                        .build()))
+                .isInstanceOf(StatusRuntimeException.class)
+                .hasMessage("INVALID_ARGUMENT: not a valid Foo, id length must be at least 5 characters");
+
+        assertThatCode(() -> fooBlockingStub.insertFoo(Foo.newBuilder()
+                        .setId("") // invalid
+                        .setName("aaaaaa")
+                        .addHobbies("coding") // invalid
+                        .build()))
+                .isInstanceOf(StatusRuntimeException.class)
+                .hasMessage("INVALID_ARGUMENT: not a valid Foo, id length must be at least 5 characters");
+
+        assertThatCode(() -> fooBlockingStub.insertFoo(Foo.newBuilder()
+                        .setId("11111")
+                        .setName("aaaaaa")
+                        .addHobbies("movies")
+                        .build()))
+                .doesNotThrowAnyException();
+    }
 }