Inconsistencies in proto_nd_flow Geometry Resource Source Code Labeling

[edhinkle]

The proto_nd_flow geometry resource source code is located in ndlar_flow/src/proto_nd_flow/resources/geometry.py. Inconsistencies include:

• The create_regions method still assumes that the drift direction is z. This also affects the regions property, which saves the active TPC volume from the geometry input file. Additionally, this affects the in_fid method, which checks whether or not points are in the detector fiducial volume given the active TPC volume and configurable fiducial volume cuts. From my initial checks, the in_fid method only comes up in analysis source code and in the electron_lifetime tool, neither of which are fully integrated into proto_nd_flow at the moment.

• Throughout the file, methods are labeled with the old coordinate convention. For instance, anode_z is a lookup table for the anode “z” coordinate, which is really the anode x coordinate in the new geometry. Other examples include the pixel_xy and get_z_coordinate methods. As Kevin noted in the meeting, these methods are used correctly in alignment with the new geometry in files such as ndlar_flow/src/proto_nd_flow/reco/charge/calib_prompt_hits.py, but this could cause future confusion (i.e. see here where the x coordinate in the output dataset is assigned from the z array).

• Also throughout the file, distance units are noted to be mm instead of cm. This can be seen, for example, in the assignment of the pixel_pitch property. Hit datasets currently use units of cm, and I can see how this might cause future confusion if someone goes back to the geometry source code to check units. There seems to be confusion as to whether cm or mm are the correct units to use within flow, so this question must also be discussed and resolved.

Issues listed are limited to those related to charge methods/properties. Furthermore, this isn’t necessarily a comprehensive list of inconsistencies within the charge-related methods/properties associated with the Geometry resource.