Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show judging timestamp in the interface #2764

Open
Kevinjil opened this issue Oct 26, 2024 · 5 comments
Open

Show judging timestamp in the interface #2764

Kevinjil opened this issue Oct 26, 2024 · 5 comments

Comments

@Kevinjil
Copy link
Contributor

Description of the enhancement request

When reviewing judgings in the admin interface, it can be relevant to know when a judging was run.

The goal you want to achieve

When problem configuration, such as testcases, have changed, it can be relevant to know when a (jury) submission has been created.
We should discuss where to put it in the interface.

Expected behaviour

  1. open /jury/submissions/<id>
  2. see judging time
@Kevinjil Kevinjil changed the title Show judging timestamp in the interfacd Show judging timestamp in the interface Oct 26, 2024
@meisterT
Copy link
Member

I changed the page recently and probably it got lost there (I thought I kept something like n minutes ago on this set of judgehosts but don't see it on demoweb).

If you change anything relevant to judging that we know of (including test data), we should show a warning message though. So if that's missing as well, we should also add it for this case.

@meisterT
Copy link
Member

meisterT commented Nov 2, 2024

It is available when you hover over how long the judging took: https://github.com/DOMjudge/domjudge/blob/main/webapp/templates/jury/submission.html.twig#L397

That is not very discoverable, but the page already has a lot of info.


When problem configuration, such as testcases, have changed, it can be relevant to know when a (jury) submission has been created.

I think we should have explicit warning messages if anything relevant has changed instead. Also, when creating a rejudging you can select a problem and rejudge all incorrect verdicts before/after a specific time:
image

@eldering
Copy link
Member

eldering commented Nov 2, 2024

It is available when you hover over how long the judging took: https://github.com/DOMjudge/domjudge/blob/main/webapp/templates/jury/submission.html.twig#L397

That is not very discoverable, but the page already has a lot of info.

I think it would be better to make it a hover over the start time in the judging table. I'd more expect it there and there's already the start time of the judging (by default in HH:MM format).

image

@meisterT
Copy link
Member

meisterT commented Nov 2, 2024

Note that we do not display the judgings table in the normal case, i.e. when no rejudging occured.

@eldering
Copy link
Member

Suggestion from IRL discussion: add before/after "took x seconds" something like "started at y".

Maybe you have input @thijskh ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants