Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base classes abstract enough in PartialGasAndIncompressible #194

Closed
wants to merge 1 commit into from

Conversation

casella
Copy link

@casella casella commented Jun 19, 2024

Fixes #193

@IngelaLind
Copy link
Contributor

I have tested this change and unfortunately it leads to other problems. I have made a pull request with a more restrictive solution.

@casella
Copy link
Author

casella commented Jun 27, 2024

OK.

@casella casella closed this Jun 27, 2024
@tobolar
Copy link
Contributor

tobolar commented Jul 1, 2024

I have made a pull request with a more restrictive solution.
@IngelaLind Please link that PR in your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liquid and Gas sub-packages should probably have more general base classes
3 participants