MoistAir entropy and isentropicExponent issue #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oistAir.specificEntropy and added 3 Test Models for further discussion
dzimmer
reviewed
Mar 18, 2024
tobolar
changed the title
|
What is the reason for this being a draft? I would otherwise go on with the regression test |
|
I think jakub suggested the PR to be a draft, because i called the package "MoistAirDiscussion" and wrote "I assume" and "I suggest" in the docu, since im no expert in the media model but just noticed some issues at saturation where the media model retuns not reasonable results without warning the user, and maybe also since we said we might want to tell the MSL directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added assert(relativeHumidty<=1) to MoistAir.isentropicExponent and MoistAir.specificEntropy and added 3 Test Models for further discussion closes #169