Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoneSense Crash #75

Open
Nekuromu opened this issue Mar 8, 2021 · 10 comments
Open

StoneSense Crash #75

Nekuromu opened this issue Mar 8, 2021 · 10 comments
Labels

Comments

@Nekuromu
Copy link

Nekuromu commented Mar 8, 2021

Game crashes when I move camera to the very top of my current fortress map, seems like #68

stderr.log

@lethosor
Copy link
Member

lethosor commented Mar 8, 2021

Moving to the Stonesense repo. The libpng warnings are a bit unusual to see on Windows (as far as I know) but are probably unrelated to the crash, unfortunately.

@lethosor lethosor transferred this issue from DFHack/dfhack Mar 8, 2021
@lethosor lethosor added the Crash label Mar 8, 2021
@Nekuromu
Copy link
Author

Nekuromu commented Mar 8, 2021

So, with a bit more tinkering I believe I have at least narrowed down the "offending" area that triggers the crash.

image

This seems to be the triggering spot, if Stonesense is open at any point in this spot it will crash. As long as it is off screen it will stay up. I have only briefly played DF throughout the years. Maybe it's related to this structure? (It's a Troglodyte building made of leather)

image

Same effect on this z-level upper right corner, structure made of spider silk.

being underneath (confirmed) or above (presumed) these structures causes no issues so a workaround would be to just avoid the "offending" z-levels of the structures. (or just don't open stonesense at all)

I wonder if the save from #63 has any buildings on the map as well.

@lethosor
Copy link
Member

lethosor commented Mar 8, 2021

Thanks for narrowing it down! The save from #63 is no longer available - could you upload yours? I think GitHub will take it if it's under 25 MB. I honestly have no idea how to find those structures, so it would help to have a save to try to reproduce this issue in.

@Nekuromu
Copy link
Author

Nekuromu commented Mar 9, 2021

Sure thing, GithHub actually only takes up to 10MB it seems.

So I did the same thing the other person did on problem #63 and used google drive. (it's compressed via winrar also)

here is the link.

note: This isn't as "fresh" as a save as it was in the first pictures. I went ahead with playing in this fortress without stonesense and there aren't any other irregularities thus far. The crashes still happen if StoneSense is turned on and those "offending areas" are on screen, and as theorized definitely seem connected to those structures. I believe you could technically play on this save crash free with StoneSense as long as kept them from being on screen at any point.

So, at least it's reproducible easily in this save.

@lethosor
Copy link
Member

Hm, GitHub's docs aren't accurate, then. I'll try out your save - thanks!

@lethosor
Copy link
Member

Unfortunately I'm not able to reproduce this (on linux64 0.47.05-r1). Screenshots of these two structures in Stonesense are below.

It likely won't help, but have you tried upgrading to DFHack 0.47.05-r1? Are you opening Stonesense before or after the fortress loads? I'm opening it after, and I'm not sure if the state transition when loading a game could cause issues.

image
image

@Nekuromu
Copy link
Author

Hmm, I am currently using DFHack version 0.47.05-beta1 (release) on x86_64. I wonder if it's related specifically to Windows? I have actually tried both loading before, and then after and this still occurs. Very interesting indeed.

@lethosor
Copy link
Member

I'm curious if 38f6d4c could have helped with this. You can try it with the build from https://buildmaster.lubar.me/applications/3/builds/build?buildId=9765 when it's done - it should contain a build of Stonesense that works with 0.47.05-r1, and I think just dropping in hack/plugins/stonesense.plug.dll would work (it won't work with 0.47.05-beta1, though).

@Nekuromu
Copy link
Author

Nekuromu commented Mar 11, 2021

just moved to 0.47.05-r1, still persists. I just wanted to be sure... I guess I will await that build when it's done and report back here if it is solved.

@realSquidCoder
Copy link
Contributor

Can someone check if this has been fixed by #104? And if so can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants