You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
since this would change types of public API, we would introduce it in a two-staged manner:
non-breaking:
allo the new class -- since the new classes inherit from the old one, all is good ComponentEvidence(..., copyright: CopyrightRepository|SortableStringables)
dont change the typeof the property -- since the new classes inherit from the old one, all is good copyright: SortableStringables
breaking: remove any usage of non-public classes in public API.
prepare a breaking change, but dont mere it yet; have it added to the next major milestone.
see must not use internals for public API #1193
The text was updated successfully, but these errors were encountered:
some properties and constructor parameters use internal types, like
SortableStringables
.this is an issue, as these internals are not exported. they can not be used downstream.
It prevents usage like follows:
context
some symbols are mark as internals, they are not exported, and they are not public API.
see https://cyclonedx-javascript-library.readthedocs.io/en/latest/typedoc/node/modules/_internal_.html
but yet, some internals are used in public API, as properties or parameters.
requirements / goals
They miught be used for inheritance, still.
solution
have dedicated classes, that are properly exported and public API.
for example
just like we did before:
cyclonedx-javascript-library/src/enums/vulnerability/analysisResponse.ts
Line 30 in fca1db5
considerations
since this would change types of public API, we would introduce it in a two-staged manner:
ComponentEvidence(..., copyright: CopyrightRepository|SortableStringables)
copyright: SortableStringables
prepare a breaking change, but dont mere it yet; have it added to the next major milestone.
see must not use internals for public API #1193
The text was updated successfully, but these errors were encountered: