Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone BOM in memory #348

Open
thompson-tomo opened this issue Sep 5, 2024 · 0 comments · May be fixed by #352
Open

Clone BOM in memory #348

thompson-tomo opened this issue Sep 5, 2024 · 0 comments · May be fixed by #352

Comments

@thompson-tomo
Copy link
Contributor

thompson-tomo commented Sep 5, 2024 •
edited
Loading

Currently BOM's are being cloned by serialising the BOM to protobuf and then de-serializing the string to a new BOM. This serialization was done as a shortcut and should be replaced with an in-memory deep copy.
thompson-tomo added a commit to thompson-tomo/cyclonedx-dotnet-library that referenced this issue Sep 5, 2024
@thompson-tomo
CycloneDX#348 implement deep copy rather than serialization
c93e130
thompson-tomo added a commit to thompson-tomo/cyclonedx-dotnet-library that referenced this issue Sep 8, 2024
@thompson-tomo
CycloneDX#348 implement deep copy rather than serialization
3ab5562 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo thompson-tomo linked a pull request Sep 8, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#348 implement deep copy rather than serialization thompson-tomo/cyclonedx-dotnet-library
1 participant
@thompson-tomo