Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAM + VM Configuration #111

Open
1 task done
wajwuz opened this issue Aug 16, 2024 · 8 comments
Open
1 task done

IPAM + VM Configuration #111

wajwuz opened this issue Aug 16, 2024 · 8 comments
Labels
enhancement New feature or request
Milestone

Comments

@wajwuz
Copy link

wajwuz commented Aug 16, 2024

Is there an existing feature request for this?

  • I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

Support for IP's over DHCP (MAC address), MTU setting for VM's.

Describe the solution you'd like.

Convoy doesn't support IP's over MAC address from DHCP network also if someone is tunnelling his IP's he might have lower MTU than 1500 but Convoy overwrites this even VM template has all this setup correctly.

Additional context to this request.

No response

@wajwuz wajwuz added the enhancement New feature or request label Aug 16, 2024
@ericwang401
Copy link
Collaborator

I can make it so that Convoy doesn't override configuration, but you're going to have to elaborate about support for IPs over DHCP. It's not clear whether it is possible through Proxmox's API to do this.

@ericwang401 ericwang401 added the question Further information is requested label Oct 10, 2024
@wajwuz
Copy link
Author

wajwuz commented Oct 10, 2024

I think adding option MTU while adding node would be great and when it's empty it will use default value 1500.

And here's the option I talked about:

  • First is "Bandwidth limit" which is rate in PVE
Screenshot 2024-10-10 at 9 53 57 PM
  • Second is "MTU" which convoy overwrite by default and I had to manually change the code.
    ^ Screenshot above

  • Third is "Setting only MAC address on IPAM". Currently we need to provide: IP, GW, CIDR which we can replace by MAC addresses with DHCP. And this is because Netplan on Ubuntu doesn't like gateways outside the subnet of allocated IP, for example: 1.2.3.4/32 and gw: 4.3.2.1. Maybe there should be and DHCP option with -- input MAC address

Screenshot 2024-10-10 at 9 51 48 PM

Also I found this:
Screenshot 2024-10-10 at 9 52 02 PM

Which can be located at PVE API: https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/qemu POST

@ericwang401
Copy link
Collaborator

Should MTU be set depending on the network interface or should all VMs in a node have the same MTU? I'm looking for what's the best way to implement this.

@wajwuz
Copy link
Author

wajwuz commented Nov 18, 2024

Yes, MTU should be inherited from network interface.

@ericwang401 ericwang401 removed the question Further information is requested label Nov 18, 2024
@ericwang401 ericwang401 added this to the vX milestone Nov 18, 2024
@staalexa
Copy link

But convoy should not override if something custom is set already in proxmox.

@ericwang401
Copy link
Collaborator

But convoy should not override if something custom is set already in proxmox.

Well that would be a bit hard to tell if a value was set by a user or was supposed to be overridden.

@staalexa
Copy link

You could set it during installation, and not override every few seconds (not like the network speed thing)

@ericwang401
Copy link
Collaborator

You could set it during installation, and not override every few seconds (not like the network speed thing)

The rate limiter currently only sets the network speed in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants