Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting to alpaka's new CMake installation routines #6

Open
j-stephan opened this issue Mar 3, 2020 · 1 comment
Open

Adapting to alpaka's new CMake installation routines #6

j-stephan opened this issue Mar 3, 2020 · 1 comment
Labels

Comments

@j-stephan
Copy link

I am currently working on the spack module for alpaka in order to reflect the recent changes to alpaka's CMake infrastructure. I noticed that all older alpaka releases are installable by uncommenting a few lines. However, these would collide with the new CMake based approach which should amount to essentially the following:

def cmake_args():
    args = ['-Dalpaka_BUILD_EXAMPLES=OFF', '-DBUILD_TESTING=OFF']

def setup_dependent_run_environment(self, spack_env, run_env, dependent_spec):
    spack_env.prepend_path('CMAKE_MODULE_PATH', self.prefix)

Do we still want to keep the older routines or can they be removed?

@ax3l
Copy link
Member

ax3l commented Apr 6, 2020

Sorry for the late reply.

Since it's only a few lines, you can add @when('@:up-to-last-old-version') decorators to functions or do spec.satisfies('@:up-to-last-old-version') in function bodies.

But since the primary consumer was PIConGPU which had shipped an internal copy of Alpaka, you can also remove the old versions here. The old install was a hack and once your new updates are merged herein and well-tested for some time, we can start to mainline the alpaka package into Spack upstream.

@ax3l ax3l added the question label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants