Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettingsExpander not showing title and description on Wasm/Uno #393

Open
Arlodotexe opened this issue Apr 4, 2024 · 14 comments
Open

SettingsExpander not showing title and description on Wasm/Uno #393

Arlodotexe opened this issue Apr 4, 2024 · 14 comments
Labels
bug Something isn't working Uno Issues related to Uno Platform

Comments

@Arlodotexe
Copy link
Member

Arlodotexe commented Apr 4, 2024

The SettingsExpander is not showing title or description when running on Wasm.

image
Originally posted by @lukasf in #383 (comment)

Second issue I noticed: SettingsExpander is still not working on any Uno targets: The header and icons are not shown. The control can be expanded and content is shown, but the header is completely empty.

You can also see this here: https://toolkitlabs.dev/

This was also the case in all older Uno WCT builds, so it is not a new bug. But since you now officially support Uno from WCT 8, it would be great if you can look into this.

@Arlodotexe Arlodotexe added bug Something isn't working Uno Issues related to Uno Platform labels Apr 4, 2024
@Arlodotexe Arlodotexe moved this to 🔖 Ready in Toolkit 8.x Apr 4, 2024
@niels9001
Copy link
Collaborator

#321 might be related.

@MartinZikmund does this ring a bell?

@MartinZikmund
Copy link
Contributor

@niels9001 not really, it sounds like a data binding issue, we will have to investigate

@lukasf
Copy link

lukasf commented May 10, 2024

Any update on this @MartinZikmund?

This is one of the best new controls in WCT, it would be great if we can use it in Uno as well.

@MartinZikmund
Copy link
Contributor

MartinZikmund commented May 14, 2024

We will make sure this is handled asap, most likely though the fix will have to be on the Uno Platform side, and we also need the WCT 8.1 update which will include Uno 5.x support 👍

@Arlodotexe
Copy link
Member Author

@MartinZikmund main branch should have the latest from Uno, would you be willing to help check these for us?

@Youssef1313
Copy link
Contributor

Could this have been fixed with #452 ?

Would someone be able to verify?

@Youssef1313
Copy link
Contributor

This is how it's rendering for me on https://toolkitlabs.dev/

image

@niels9001
Copy link
Collaborator

This is how it's rendering for me on https://toolkitlabs.dev/

image

That's SettingsCard, not Expander. Could you try that to see if the issue is resolved? Maybe one of the recent Uno updates fixed the issue..

@Youssef1313
Copy link
Contributor

Ah sorry. Yes it's still broken it seems.

@ajpinedam
Copy link
Contributor

Hi 👋

I am looking into this issue from the Uno Platform side. Who can guide me in compiling and running the CommunityToolkit.Windows project/solution locally?

cc: @niels9001

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Aug 22, 2024

Hi 👋

I am looking into this issue from the Uno Platform side. Who can guide me in compiling and running the CommunityToolkit.Windows project/solution locally?

cc: @niels9001

@ajpinedam You can find our Quick Start guide here, otherwise we're available on GitHub and Discord if you run into issues!

@michael-hawker
Copy link
Member

@ajpinedam any luck in investigating what might be going on here? Were you able to setup and run the projects from our repo?

@Youssef1313
Copy link
Contributor

@michael-hawker This may have gotten fixed with latest Uno dev bits. Any chance you could double check?

@ajpinedam
Copy link
Contributor

@michael-hawker, as @Youssef1313 mentioned, this was fixed. Please use one of the latest dev versions of Uno whenever you can and validate the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Uno Issues related to Uno Platform
Projects
Status: 🔖 Ready
Development

No branches or pull requests

7 participants