Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart title not visible above the chart in chartJS library #1133

Closed
vytisbulkevicius opened this issue Apr 30, 2024 · 0 comments · Fixed by #1132
Closed

Chart title not visible above the chart in chartJS library #1133

vytisbulkevicius opened this issue Apr 30, 2024 · 0 comments · Fixed by #1132
Assignees
@GrigoreMihai
Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less. Priority-Medium Expected resolution time - up to 1 month.
Milestone
3.11

Comments

@vytisbulkevicius
Copy link
Contributor

vytisbulkevicius commented Apr 30, 2024 •
edited
Loading

Description

As we're working on introducing edition for the backend title - https://github.com/Codeinwp/visualizer-pro/issues/445

I noticed that for charts when chartJS library is used the title doesn't appear in the front-end (above the chart) as it should be.
image

I can add it via Manual configuration:
image

But it should be controllable via settings as well.

For reference - https://www.chartjs.org/docs/latest/configuration/title.html

Step-by-step reproduction instructions

Try to add Title for chartJS library charts.

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No
@vytisbulkevicius vytisbulkevicius added bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. labels Apr 30, 2024
@vytisbulkevicius vytisbulkevicius added this to the 3.11 milestone May 1, 2024
@vytisbulkevicius vytisbulkevicius added the medium (1d) - This label is used for issues that can be completed within 1 day or less. label May 1, 2024
GrigoreMihai added a commit that referenced this issue May 9, 2024
@GrigoreMihai
fix: improper title settings for ChartJS #1133
ef4e0a3
GrigoreMihai added a commit that referenced this issue May 9, 2024
@GrigoreMihai
fix: improper title settings for ChartJS #1133
2a896db
@GrigoreMihai GrigoreMihai mentioned this issue May 9, 2024
Merged
6 tasks
Soare-Robert-Daniel pushed a commit that referenced this issue May 10, 2024
@GrigoreMihai
fix: improper title settings for ChartJS #1133 (#1142)
ee85aa0 
* fix: improper title settings for ChartJS #1133

* chore: removed test logs
@vytisbulkevicius vytisbulkevicius linked a pull request May 13, 2024 that will close this issue
Release #1132
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GrigoreMihai GrigoreMihai

Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less. Priority-Medium Expected resolution time - up to 1 month.
Projects
None yet
Milestone
3.11
Development

Successfully merging a pull request may close this issue.

Release Codeinwp/visualizer
2 participants
@vytisbulkevicius @GrigoreMihai