Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE/Theme Compatibility in the Editor #1050

Closed
mghenciu opened this issue Nov 14, 2023 · 3 comments
Closed

FSE/Theme Compatibility in the Editor #1050

mghenciu opened this issue Nov 14, 2023 · 3 comments
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@mghenciu
Copy link
Contributor

mghenciu commented Nov 14, 2023

Description

I tried following the the Golden Path in the Visualizer onboarding, by installing it on a test instance and import a demo chart; but it won't work in the Editor context:

image


after installing Neve instead of 2023 theme, the chart works in the editor.
Looking into Metabase feeback, I see mentions about this from 8th of November.

Note: the chart works in the front end, so the issue is visible only in the Editor.


Step-by-step reproduction instructions

  1. Crete a test instance with 2023 theme | WP 6.4.1 | Visualizer 3.10.4
  2. Start the onboarding
  3. Select the Bar Chart
  4. Finish the onboarding and select to open the Draft (demo) page

Screenshots, screen recording, code snippet or Help Scout ticket

Screen.Recording.2023-11-14.at.11.20.19.mov

Environment info

https://pastebin.com/e8YAhHNz

Is the issue you are reporting a regression

No

@mghenciu mghenciu added the bug This label could be used to identify issues that are caused by a defect in the product. label Nov 14, 2023
@mghenciu mghenciu changed the title FSE Compatibility FSE Compatibility in the Editor Nov 14, 2023
@mghenciu mghenciu changed the title FSE Compatibility in the Editor FSE/Theme Compatibility in the Editor Nov 14, 2023
@mghenciu
Copy link
Contributor Author

After doing more testing, it looks like it happens also with the Astra theme - which is not FSE.
So it may be not related only to FSE.
Screenshot 2023-11-14 at 12 17 32

@girishpanchal30
Copy link
Contributor

Hey @mghenciu,

I've reviewed this issue and the issue is related to lodash JS, I already fixed it with this PR #1048

Thanks

@irinelenache
Copy link

@girishpanchal30 Tested and the issue is fixed now, thank you 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

No branches or pull requests

4 participants