Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Feature: Set up theming combining Analog's way with PrimeNG way #22

Open
1 of 2 tasks
esthersoftwaredev opened this issue May 31, 2024 · 0 comments
Open
1 of 2 tasks

Comments

@esthersoftwaredev
Copy link
Member

esthersoftwaredev commented May 31, 2024

Type of feature

✨ Feature

Current behavior

  • Analog uses media query @media (prefers-color-scheme: light) I want to keep it
  • PrimeNG has specific setup of adjusting the angular.json, using a service and adding an element that loads stylesheets dynamically

Suggested solution

  • let's see if I can combine both

  • this one turns out to be a bit more challenging than I thought

  • cannot keep PrimeNG theming in the same file, that doesn't work as styles overwrite each other

  • I tried several implementations adding stuff to the vite.config.js

  • there has been a bit of a challenge in adding another link element directly in the index.html but I found a workaround for this

  • current biggest challenge is to separate the CSS files so that I get styles.css but also separate compiled dark.css and light.css which I can load dynamically

Additional context

  • suggestions are more than welcome

I would be willing to submit a PR to fix this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant