Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibrating AIDA HET experiments #495

Merged
merged 1 commit into from
Dec 13, 2024
Merged

calibrating AIDA HET experiments #495

merged 1 commit into from
Dec 13, 2024

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Dec 10, 2024

Purpose

  • adding experiments IN07_01 and IN07_19 to the AIDA calibrations

To-do

  • calculate and plot saturation from raw data to see if it's in deposition nucleation conditions or IMM conditions
  • properly find initial N_l
  • have m and c fields for deposition and immersion ice nucleation for different aerosol types (so that they are calibrate-able)

Content


  • I have read and checked the items on the review checklist.

@amylu00 amylu00 self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (3a3759b) to head (c79ec55).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          41       41           
  Lines        1605     1606    +1     
=======================================
+ Hits         1538     1539    +1     
  Misses         67       67           
Components Coverage Δ
src 97.48% <100.00%> (+<0.01%) ⬆️
ext 69.79% <ø> (ø)

@amylu00 amylu00 force-pushed the al/AIDA_HET branch 2 times, most recently from 1d5968c to ec73506 Compare December 13, 2024 00:28
@amylu00
Copy link
Member Author

amylu00 commented Dec 13, 2024

IN07_01:
image

IN07_19:
Screenshot 2024-12-12 at 4 31 28 PM

parcel/ParcelModel.jl Outdated Show resolved Hide resolved
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. There is one commented out line in the parcel code that I don't think should be commented? Looks good otherwise!

@amylu00 amylu00 enabled auto-merge December 13, 2024 22:39
@amylu00 amylu00 merged commit 384c393 into main Dec 13, 2024
8 checks passed
@amylu00 amylu00 deleted the al/AIDA_HET branch December 19, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants