Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to prep for AIDA HET calibs #493

Merged
merged 1 commit into from
Dec 5, 2024
Merged

refactor to prep for AIDA HET calibs #493

merged 1 commit into from
Dec 5, 2024

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Dec 5, 2024

Cleaning the AIDA_calibration.jl file for easy incorporation of the heterogeneous ice nucleation calibrations. Data file for IN05_17 was offset by 1 line so fixed the artifact and updated calibration code to adjust for it.

@amylu00 amylu00 self-assigned this Dec 5, 2024
@amylu00 amylu00 requested a review from trontrytel December 5, 2024 20:20
@amylu00 amylu00 requested a review from Sbozzolo December 5, 2024 21:39
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (3cb3864) to head (da55f8e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          41       41           
  Lines        1605     1605           
=======================================
  Hits         1538     1538           
  Misses         67       67           
Components Coverage Δ
src 97.48% <ø> (ø)
ext 69.79% <ø> (ø)

@amylu00 amylu00 merged commit a07e0d5 into main Dec 5, 2024
12 checks passed
@amylu00 amylu00 deleted the al/calib_refactor branch December 19, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants