Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the velocity perf test #427

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Bring back the velocity perf test #427

merged 1 commit into from
Jul 26, 2024

Conversation

trontrytel
Copy link
Member

The compiler was assuming there is an else at the end (even tho there wasn't) and assuming there was Nothing returned there. Hence the JET failures.

@trontrytel trontrytel added the P3 label Jul 26, 2024
@trontrytel trontrytel requested a review from rorlija1 July 26, 2024 21:14
@trontrytel trontrytel self-assigned this Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (bc5687d) to head (497016e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   96.77%   96.77%   -0.01%     
==========================================
  Files          40       40              
  Lines        1397     1396       -1     
==========================================
- Hits         1352     1351       -1     
  Misses         45       45              
Components Coverage Δ
src 98.76% <100.00%> (-0.01%) ⬇️
ext 69.79% <ø> (ø)

@trontrytel trontrytel merged commit b246f0d into main Jul 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant