Sections layout badly optimized (goes out of the screen)

[Porkepix]

Addon Version

v0.1.43

World of Warcraft Version

Retail

Describe the bug

Layout of the sections is not optimized. Some parts goes out of the screen while there's a whole lot of empty space on other columns. See here the recipes section: some of them are outside of the monitor at the bottom, and maybe other lines/sections: I have no ways to tell.

See the joined screenshot, taken on a QHD monitor (2560x1440), so above average FHD resolution. Cropped on the sides as it was irrelevant.

You can also note that some sections names are cut for no reason (I see the case for two of them on the screenshot); I can open another issue for this if necessary.

Also, I'll use the occasion of this issue for a question, to not open too many of them: BetterBags is pushed as meant for replacing AdiBags, however it's clearly not at feature parity for now. Is it meant to have it? If yes, is there an issue centralizing feature parity and things like that?

Steps to reproduce

Apart from filling your bank in a similar manner to this screenshot, it's hard to tell.

[Cidan]

A few things that help:

1. Turn on Simple compaction

2. Add more items per row, and less columns, so the bank bag has more room to grow horizontally. You do this on the main bag today as seen in your screenshot -- do that on the bank as well.

AdiBags also did a tighter set of bin packing for sections, ignoring sort order and finding a best fit. BetterBags doesn't do that in favor of strict ordering, however a bin packing feature will come soon, along with better sorting options.

Also, I'll use the occasion of this issue for a question, to not open too many of them: BetterBags is pushed as meant for replacing AdiBags, however it's clearly not at feature parity for now. Is it meant to have it? If yes, is there an issue centralizing feature parity and things like that?

No, not even close. There are still quite a few things that need to be done. The issues are scattered all over this Github in various issues.

[Porkepix]

A few things that help:

1. Turn on Simple compaction

2. Add more items per row, and less columns, so the bank bag has more room to grow horizontally. You do this on the main bag today as seen in your screenshot -- do that on the bank as well.

So we have no choice but to set this right manually? I had a good result in AdiBags without touching any parameters, just with the default settings and behavior acting smarter.

AdiBags also did a tighter set of bin packing for sections, ignoring sort order and finding a best fit. BetterBags doesn't do that in favor of strict ordering, however a bin packing feature will come soon, along with better sorting options.

What do you mean by bin packing? I'm not sure I understand what's this.

Also, I'll use the occasion of this issue for a question, to not open too many of them: BetterBags is pushed as meant for replacing AdiBags, however it's clearly not at feature parity for now. Is it meant to have it? If yes, is there an issue centralizing feature parity and things like that?

No, not even close. There are still quite a few things that need to be done. The issues are scattered all over this Github in various issues.

Then I'll ask, if I may: what's the reason/goal behind the creation of BetterBags to replace AdiBags if it's by the same persons?
Does that mean I need to open issues anyway for anything I can find missing and you'll decide on what are you planning to implement or not?

In the current state, aside slightly less bugs on BetterBags, the general look & feel, memory footprint and features of AdiBags still seems better to me and makes me want to still use it, but as I understand we should consider it as unmaintained now?

[Cidan]

So we have no choice but to set this right manually? I had a good result in AdiBags without touching any parameters, just with the default settings and behavior.

It's two sliders you have to change, but I'll change the defaults in the bank to match the bag in the next release.

What do you mean by bin packing? I'm not sure I understand what's this.

It's a computer science term -- essentially, "pack things as tight as possible without wasting space".

Then I'll ask, if I may: what's the reason/goal behind the creation of BetterBags to replace AdiBags if it's by the same persons?

I've answered this both in the AdiBags github pinned issue, and in the Discord FAQ. PTAL there :)

Thanks!

[Porkepix]

So we have no choice but to set this right manually? I had a good result in AdiBags without touching any parameters, just with the default settings and behavior.

It's two sliders you have to change, but I'll change the defaults in the bank to match the bag in the next release.

My point wasn't about it being difficult, just to have better defaults fitting most cases without any need for modification, though.

What do you mean by bin packing? I'm not sure I understand what's this.

It's a computer science term -- essentially, "pack things as tight as possible without wasting space".

Okay, that might explain why I currently feel much more comfortable with AdiBag's presentation and layout compared to BetterBags', I'll wait and see once this is implemented how does it feel then.

Then I'll ask, if I may: what's the reason/goal behind the creation of BetterBags to replace AdiBags if it's by the same persons?

I've answered this both in the AdiBags github pinned issue, and in the Discord FAQ. PTAL there :)

Thanks!

Discord is a no-go for me for many reasons (I also looked if there was some IRC/Matrix/XMPP to talk first though, as it'd have been a better way to ask questions!) and it isn't publicly accessible without account. I read the issue's announcement on AdiBag's GitHub though. Just curious about why not do a v2 which would have also been a complete rewrite to ease maintenance burden instead of changing the name though. But I guess it'd have been confusing for many people due as it doesn't have feature parity.

I'll open issues for other things missing, but I guess that despite these being present in AdiBag, it still qualifies as feature request rather than a bug report?

I'll also look at opening another issue for the sections names cut off after a few letters in bank (battle pets and main hands). I suspect it applies to sections with two words or more and a space between them.