Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame drop by opening bags #364

Closed
RathianD opened this issue May 10, 2024 · 7 comments
Closed

Frame drop by opening bags #364

RathianD opened this issue May 10, 2024 · 7 comments
Assignees
Labels
bug Something isn't working triage

Comments

@RathianD
Copy link

Addon Version

v0.1.43

World of Warcraft Version

Retail

Describe the bug

I downloaded the addon today and i noticed a 20fps frame drop every time i opened my bags but the weird thing is it does not happen when ever i open any option window like game menu or options the frame drop is basically gone maybe worth looking into it why this happens.

Steps to reproduce

I recorded it so you can see what i am talking about i hope it helps.

2024-05-10.11-03-25.mp4
@Cidan
Copy link
Owner

Cidan commented May 10, 2024

I just spent some time debugging this -- this is tricky, because what I believe is happening is the Blizzard bag is secretly drawing in the background when you show the bag. This causes a small frame drop, and I can't turn off the Blizzard bag draw function.

Does this happen with just the default Blizzard bags?

@RathianD
Copy link
Author

First of all thank you for responding! I just tested it with the default Blizzard bags and i have the same frame drops about 20 fps and with the default bags i can`t even open it whenever i have the game menu open so maybe that is the reason why the frame drop is gone because the default blizzard bags cant be used when the game menu / option is open.
The thing is before Betterbags i was using Adibags and there was little to none frame drops maybe 2-4 i dont know if they found a way to reduce it but thats why i asked if this is normal.

@RathianD
Copy link
Author

I just thought about it is there a way to trick the default bags into thinking the game menu is somehow open ^^

@Cidan
Copy link
Owner

Cidan commented May 10, 2024

That's so funny, I was just debugging this with another bag addon author and we JUST figured that out as well. There is currently no way to make the Blizzard bags not render in the background -- we put in a request with Blizzard to add a feature for us to do this though. Probably won't happen, but, you never know!

Thanks for the report.

@RathianD
Copy link
Author

Well that saddles it fingers crossed! Thank you very much for taking the time and looking into it :)

@Cidan Cidan closed this as completed May 10, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Released in BetterBags Issue Tracker May 10, 2024
@Cidan
Copy link
Owner

Cidan commented May 10, 2024

@RathianD With the help of some other folks, we've come up with a solution that I have in testing now. If you download the latest Alpha build of BetterBags (curse, wago, etc), you should get no frame drops at all when opening the bag.

Let me know how it goes!

@RathianD
Copy link
Author

Well what ever you guys come up with it works Like a Charm!! The Frame Drops are completely gone 🥳 thank you so much ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
Archived in project
Development

No branches or pull requests

2 participants